remove p-map and fix jasmine promise chain
#3880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3880 +/- ##
=========================================
+ Coverage 57.65% 58% +0.35%
=========================================
Files 195 195
Lines 6782 6744 -38
Branches 6 6
=========================================
+ Hits 3910 3912 +2
+ Misses 2869 2829 -40
Partials 3 3
Continue to review full report at Codecov.
|
|
@SimenB I just thought about the same, but that doesn't seem to help. |
|
@cpojer said there's more context to this and didn't want me to merge this one yesterday. e.g. // in the inner VM scope:
const innerVMScopeContext = new InnerVMScopeContext({
Symbol,
Error,
Function,
// etc...
});
// return this object to the outer scope where it can be used for whatever it needs to be used for
return innerVMScope; |
packages/jest-jasmine2/src/index.js
Outdated
| @@ -92,8 +92,9 @@ function jasmine2( | |||
| env.specFilter = spec => testNameRegex.test(spec.getFullName()); | |||
| } | |||
|
|
|||
| runtime.requireModule(require.resolve('p-map')); | |||
There was a problem hiding this comment.
Why is this needed here?
There was a problem hiding this comment.
i thought that would help, but it didn't :)
i ended up removing p-map completely and that helped. I'll remove this line
|
|
||
| let promise = Promise.resolve(); | ||
|
|
||
| options.queueableFns.forEach(fn => { |
There was a problem hiding this comment.
This could be replaced with reduce, without creating variable, right?
aaronabramov
force-pushed
the
iterator-to-null
branch
from
3d0bb2c
to
fd46ea1
Compare
aaronabramov
changed the title
jasmine from outer VM scopep-map and fix jasmine promise chain
aaronabramov
force-pushed
the
iterator-to-null
branch
from
fd46ea1
to
9d6b70e
Compare
* iterator-to-null test * move jasmine back to inner scope / don't use iterators
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
this PR fixes two problems:
Array.prototype[Symbol.iterator] = nullstalls the process #3879)Taking jasmine out seems risky, but all tests seem to be passing