Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade lerna #14698

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: upgrade lerna #14698

merged 1 commit into from
Nov 16, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 16, 2023

Summary

This is done to get v10 of node-gyp which is needed for python 3.12 support.

I locked down the version of Lerna earlier as it pulled in newer make-fetch-happen etc. that exploded our lockfile. Other deps have caught up now though, so no longer needed.

As an aside, I still want to set up e.g. changesets and have releases from CI rather than manual ones like today. But merge access on PRs shouldn't be the same as publish access on npm, so I need to figure out which branch protection rules or whatever I need to set up in order to only allow certain people to merge

Test plan

Green CI

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 482f604
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6555d4720777aa0008911e8a
😎 Deploy Preview https://deploy-preview-14698--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -12,7 +12,8 @@
"@crowdin/cli": "^3.5.2",
"@jest/globals": "workspace:*",
"@jest/test-utils": "workspace:*",
"@lerna-lite/cli": "1.13.0",
"@lerna-lite/cli": "^2.0.0",
"@lerna-lite/publish": "^2.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB SimenB enabled auto-merge (squash) November 16, 2023 08:53
@SimenB SimenB merged commit 942aa53 into jestjs:main Nov 16, 2023
69 of 71 checks passed
@SimenB SimenB deleted the upgrade-lerna branch November 16, 2023 09:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant