Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-util): make sure isInteractive works in a browser #14552

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 20, 2023

Summary

Fixes #14428

Test plan

Should probably add a Playwright test or something that verifies it works correctly bundled by Vite. I'll skip that for now, tho

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 91cd04b
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/650ad6e6a2dc010008fd69b1
😎 Deploy Preview https://deploy-preview-14552--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB enabled auto-merge (squash) September 20, 2023 07:15
@SimenB SimenB disabled auto-merge September 20, 2023 11:26
@SimenB SimenB merged commit f38c05c into jestjs:main Sep 20, 2023
1 of 4 checks passed
@SimenB SimenB deleted the is-interactive-browser branch September 20, 2023 11:26
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: expect library vite support
1 participant