-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Prettier to v3 #14311
Upgrade Prettier to v3 #14311
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Apparently inline snapshots fail to update if Prettier v3 is installed. The existing once work fine until they are passing, only It might be good to fix the problem before merging this PR. Seems like this is similar to what |
Hmm, I was hoping we were still using prettier v2 with this. Might need to add a dev dep to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw lots of changes related to format, maybe you should minimize the size of this PR with focus on remove the unnecessary formatting-related changes.
Also, there are files with .js
extension that includes types, why is that?
Thanks for the changes!
Co-authored-by: Cristóbal Gajardo Vera <[email protected]>
|
Played around some more with using |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This is #14108 without changing the version used by our packages - just the version of prettier used to format the jest code base
Test plan
Green CI