fix(jest-resolve): Remove redundant realpath
call
#14053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes a redundant call to
realpathCached
.resolve
already callsrealpath
due topreserveSymlinks: false
so the subsequentrealpathCached
call was redundant.In test suites resolving a lot of files,
realpathCache
can become a real hotpath. Since resolving files is done during test-setup, it's important that resolving modules is as fast as possible. So even if we know we'll hit the cache, we should avoid calling at all if we know for certain it's just hitting the cache. Since these calls are right next to each other I don't see the danger of accidentally not resolving symlinks.Test plan