Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-runtime): do not call resetAllMock() during teardown #13924

Merged
merged 1 commit into from
Feb 23, 2023
Merged

refactor(jest-runtime): do not call resetAllMock() during teardown #13924

merged 1 commit into from
Feb 23, 2023

Conversation

mrazauskas
Copy link
Contributor

Summary

There is no need to call resetAllMocks() after restoreAllMocks(), because it does nothing (as one can see below, logic in jest-mock):

https://github.com/facebook/jest/blob/d8e29382c9cb83f6f7a712c9dc2835b69a81e5f5/packages/jest-mock/src/index.ts#L1446-L1457

restoreAllMocks() already cleared mocks and their registry. The spyState will also be empty.

Test plan

Green CI.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@SimenB SimenB merged commit 39a0e05 into jestjs:main Feb 23, 2023
@mrazauskas mrazauskas deleted the refactor-do-not-call-resetAllMock branch February 23, 2023 08:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants