Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical errors in docs #13635

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Fix grammatical errors in docs #13635

merged 1 commit into from
Dec 31, 2022

Conversation

rnwst
Copy link
Contributor

@rnwst rnwst commented Nov 22, 2022

Changed occurrences of 'ran' to 'run', such as in 'will not be ran' (which is incorrect).

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB
Copy link
Member

SimenB commented Dec 20, 2022

Would you be up for changing the versioned docs as well?

Changed occurrences of 'ran' to 'run', such as in 'will not be ran' (which is incorrect).
@facebook-github-bot
Copy link
Contributor

Hi @rnwst!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@rnwst
Copy link
Contributor Author

rnwst commented Dec 20, 2022

I've updated the versioned docs as well and amended the commit. I've also signed the CLA.
For reference, I changed the remaining errors in the versioned docs as follows:

sed -i 's/to be ran/to be run/g;s/will not be ran/will not be run/g;s/will be ran/will be run/g' */*.md

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@rnwst
Copy link
Contributor Author

rnwst commented Dec 27, 2022

@SimenB Anything else that needs to be done before this can be merged?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 050d1ab into jestjs:main Dec 31, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants