Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a seed value to test runs #13400
feat: add a seed value to test runs #13400
Changes from all commits
886a1e2
d551da5
4e44bef
0877be4
d1f5311
49c060f
bc8b4eb
c5ca4d7
fecf106
c39e63f
923f556
07f7b55
3987577
dda334e
3c61bc2
08e53ac
e848382
9424589
83f5e9a
bfcc0b4
3e78642
ba7f269
40047fe
6730725
589d434
4eafd79
ebdf7cb
116bdca
b7d5faa
c7d196a
d2af3a6
2ea7dc6
b9b8abf
679521b
adda4f7
01ac6f3
71c04c4
1fee0a7
7b97aab
076eb02
d0eed4a
523b995
1328b7b
1aae653
d568629
e246b8a
3efe6fc
0fb3e79
d023a21
535730b
3cb272b
b8a70eb
b2021e5
91212a2
ed5f9c1
157ea7e
cf0230c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a great option, I love it 💕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just about to tag you 🙂 Does this (i.e. this entire implementation, not just this specific option) fit your use case and usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking you can just document setting this config flag instead of printing the seed yourself (as a major release I guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will definitely help a lot. So far
@fast-check/jest
was mostly responsible for building a seed forfast-check
and appending it to the name of theit
(and also provide ait
tailored for pbt). With bothseed
andshowSeed
options altering the name of the test might not be that required.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't documented the removal of the seed printing yet, but that was my idea when I opened dubzzz/fast-check#3287