Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint files in website/blog directory #13379

Merged
merged 5 commits into from
Oct 4, 2022
Merged

chore: lint files in website/blog directory #13379

merged 5 commits into from
Oct 4, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

For some reason currently ESLint is told to ignore file in website/blog directory. Hm.. Let’s lint those too? Why not? ;D

Test plan

Green CI.

@mrazauskas mrazauskas marked this pull request as draft October 4, 2022 07:49
@mrazauskas mrazauskas marked this pull request as ready for review October 4, 2022 07:58
@@ -180,7 +180,6 @@ module.exports = {
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'arrow-body-style': 'off',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'plugin:prettier/recommended' is adding this one

@@ -101,7 +102,14 @@ test('my mocking test', () => {
},
],
],
"results": Array [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we have this in jest 22?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Just looked at the code, it was not there indeed.

@SimenB SimenB merged commit 3904eb8 into jestjs:main Oct 4, 2022
@mrazauskas mrazauskas deleted the chore-lint-blog-files branch October 4, 2022 08:46
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants