chore(lint): use jest/prefer-to-have-length rule
#13370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Oct 3, 2022
| @@ -349,7 +349,7 @@ jest.mock('./sound-player', () => { | |||
| }); | |||
| ``` | |||
|
|
|||
| This will let us inspect usage of our mocked class, using `SoundPlayer.mock.calls`: `expect(SoundPlayer).toHaveBeenCalled();` or near-equivalent: `expect(SoundPlayer.mock.calls.length).toBe(1);` | |||
| This will let us inspect usage of our mocked class, using `SoundPlayer.mock.calls`: `expect(SoundPlayer).toHaveBeenCalled();` or near-equivalent: `expect(SoundPlayer.mock.calls.length).toBeGreaterThan(0);` | |||
There was a problem hiding this comment.
| @@ -167,6 +167,8 @@ module.exports = { | |||
| 'jest/no-focused-tests': 'error', | |||
| 'jest/no-identical-title': 'error', | |||
| 'jest/prefer-to-be': 'error', | |||
| 'jest/prefer-to-contain': 'error', | |||
There was a problem hiding this comment.
jest/prefer-to-contain is added for completeness. It did not find any errors, but that is not yet enough to use extends: ['plugin:jest/style'].
Comment on lines
-18
to
+19
| expect(importedFn.mock.calls.length).toBe(1); | ||
| expect(localFn.mock.calls.length).toBe(1); | ||
| expect(importedFn).toHaveBeenCalledTimes(1); | ||
| expect(localFn).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
These were reworked manually (here and in other files).
SimenB
reviewed
Oct 3, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also
jest/prefer-to-have-lengthrule could be added to ESLint config. Quick search shows that currentlytoHaveLengthmatcher is used 81 time in 36 files (excluding*.md). Let’s add few more?Test plan
Green CI.