chore: typecheck example and test files #13353
Conversation
| const defaultBabelJestTransformer = babelJest.createTransformer(null); | ||
| const defaultBabelJestTransformer = babelJest.createTransformer(); |
There was a problem hiding this comment.
null is not allowed, but could be undefined. Perhaps it is fine to call it with no args:
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ |
There was a problem hiding this comment.
Import of beforeEach was missing. After adding it, the test is failing. This change fixed the test. Reference: https://angular.io/guide/testing-components-scenarios#consolidated-setup
|
Looks like all is working. |
| @@ -50,6 +50,10 @@ jobs: | |||
| run: yarn test-ts --selectProjects type-tests | |||
| - name: verify [email protected] compatibility | |||
| run: yarn verify-old-ts | |||
| - name: typecheck examples | |||
There was a problem hiding this comment.
At first I though to run these before type tests. The workflow is stopped after first fail. Feels like feedback from type tests could be more useful. Actually that is not so important, because it is possible to run any of these checks locally.
| @@ -4,6 +4,7 @@ | |||
| "composite": false, | |||
| "emitDeclarationOnly": false, | |||
| "noEmit": true, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
Very good idea to keep config in a single root file ;D
| @@ -110,6 +110,9 @@ | |||
| "test-ts": "yarn jest --config jest.config.ts.mjs", | |||
| "test-types": "yarn test-ts --selectProjects type-tests", | |||
| "test": "yarn lint && yarn jest", | |||
| "typecheck": "yarn typecheck:examples && yarn typecheck:tests", | |||
| "typecheck:examples": "tsc -p examples/angular --noEmit && tsc -p examples/expect-extend --noEmit && tsc -p examples/typescript --noEmit", | |||
There was a problem hiding this comment.
Using -p here, because --noEmit is not allow with -b. And it does not look right to have noEmit in example configs.
There was a problem hiding this comment.
Can we use -b instead and pass all projects at once?
There was a problem hiding this comment.
In -b something --noEmit it is not allow to have --noEmit. Or you mean I include add noEmit: true to tsconfigs of examples? It felt strange to have it there, because that is not what one would do in real world.
| expect((result as BabelFileResult).map!.sources).toEqual(['dummy_path.js']); | ||
| expect( | ||
| JSON.stringify((result as BabelFileResult).map!.sourcesContent), | ||
| ).toMatch('customMultiply'); |
There was a problem hiding this comment.
Ah.. BabelFileResult is maybe even better since this is babel-jest test. The value and type comes from Babel:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It would be nice to typecheck test files in CI. To make sure the test stay up to date and to have more tests for Jest types. For the start these are test files of three packages with types fixed and typecheck set up.
CI runs on the
examplesfolder too, so I added type checks for examples written in TypeScript.Test plan
If everything is setup correctly,All works as expected.tscshould find two type errors. (Which I will fix, of course.)