Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace
@types/jest
with a new private@jest/test-globals
package #13344chore: replace
@types/jest
with a new private@jest/test-globals
package #13344Changes from 10 commits
e88b376
dac1388
fa584ca
eb97554
377d18d
65b31f0
3aaa602
04b951d
46af508
4811560
570a953
2d60a2b
6cb1488
0fa510d
dcd66d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? how? it's running in node env, so shouldn't need or use any DOM APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd one.
Window
type does not work without"dom"
:https://github.com/facebook/jest/blob/aae0d3ac3498ece4673ec29277dc040234f9f643/packages/jest-fake-timers/src/__tests__/legacyFakeTimers.test.ts#L464-L467
And it is used to type
requestAnimationFrame
:https://github.com/facebook/jest/blob/aae0d3ac3498ece4673ec29277dc040234f9f643/packages/jest-fake-timers/src/__tests__/legacyFakeTimers.test.ts#L494
I added
reference
to silence a lot of type errors, but will come back to this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, for rAF it makes sense 👍