perf: don't perform V8 instrumenting if !collectCoverage #13282
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@mitchhentgesspotify could you sign the CLA? 🙂 |
|
Currently checking some boxes with my company so that I can get that CLA signed, I'm on it chief 😎 |
|
Ping? 😀 |
|
Pong 😔 I'm making progress, but I'm still "standing by" for the moment. I haven't dropped this, I promise :) |
|
Cool 👍 |
Sounds like the (existing) Spotify CLA with Facebook should now be updated to include my GitHub details. |
mitchhentgesspotify
force-pushed
the
v8-coverage-perf
branch
from
01b94cd to
c0d6a39
Compare
I'm guessing that it takes a bit for updates to |
|
Hopefully the bot picks it up yeah. It sometimes needs a kick, but a rebase or comment usually helps, so let's see |
mitchhentgesspotify
force-pushed
the
v8-coverage-perf
branch
2 times, most recently
from
56cab28 to
f7996e7
Compare
|
maybe closing and reopening works? |
|
@zpao any idea why the bot doesn't update? |
|
I've emailed |
If `coverageProvider: "v8"` is provided in the Jest config, then the overhead of V8 instrumenting occurs, even if `collectCoverage: false`. This saves about ~100ms of Jest-invocation-time on my machine. Signed-off-by: Mitchell Hentges <[email protected]>
mitchhentgesspotify
force-pushed
the
v8-coverage-perf
branch
from
7ca3578 to
60e10d6
Compare
Signed-off-by: Mitchell Hentges <[email protected]>
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
🎉 |
SimenB
changed the title
|
We did it 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If
coverageProvider: "v8"is provided in the Jest config, then the overhead of V8 instrumenting occurs, even ifcollectCoverage: false.This saves about ~100ms of Jest-invocation-time on my machine.