chore: update @babel/core
#13245
Merged
chore: update @babel/core
#13245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Babel should only hide its own stack frames; this looks like a bug. |
|
@nicolo-ribaudo See #13248 for a slightly less convoluted reproduction. Should I open up an issue in the Babel repo? |
robhogan
added a commit
to robhogan/metro
that referenced
this pull request
Oct 18, 2022
Summary: Following on from D39543504 (facebook@69607ae) and D40379963, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template. Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment. [General] [Changed] - Upgrade Jest in React Native template to ^29.2.1 Differential Revision: D40386349 fbshipit-source-id: f324df6b80cff474cd357a37ce50b832375abeac
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Oct 18, 2022
Summary: X-link: facebook/metro#881 Following on from D39543504 (facebook@c27501b) and D40379963 (facebook@8f33753), this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template. Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment. [General] [Changed] - Upgrade Jest in React Native template to ^29.2.1 Differential Revision: D40386349 fbshipit-source-id: 524a6f19008abcd5b0dad02ef2c3f1c39d10cc29
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Oct 19, 2022
Summary: X-link: facebook/react-native#35014 Pull Request resolved: #881 Following on from facebook/react-native#34724 and facebook/react-native#34972, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template. Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment. Changelog: [General] [Changed] - Upgrade Jest in React Native template to ^29.2.1 Reviewed By: jacdebug Differential Revision: D40386349 fbshipit-source-id: 43f5a69cf546df09e2f02542ebf50130d65f0436
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 19, 2022
Summary: Pull Request resolved: #35014 X-link: facebook/metro#881 Following on from #34724 and #34972, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template. Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment. Changelog: [General] [Changed] - Upgrade Jest in React Native template to ^29.2.1 Reviewed By: jacdebug Differential Revision: D40386349 fbshipit-source-id: 43f5a69cf546df09e2f02542ebf50130d65f0436
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This for some reason loses a stack trace in https://github.com/facebook/jest/blob/27b46b65aa8c5e8ecb1608ec1aa426b771e600e2/e2e/__tests__/jest.config.ts.test.ts
I'm not certain this is bad per se, but it's a surprising change.
@nicolo-ribaudo thoughts? I assume it's from babel/babel#11554
Test plan
Update the snapshot? 😅