Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-config): use a single mergeOptionWithPreset() function for option merging #13190

Merged
merged 1 commit into from
Aug 30, 2022
Merged

refactor(jest-config): use a single mergeOptionWithPreset() function for option merging #13190

merged 1 commit into from
Aug 30, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

To workaround a TypeScript error, the internal mergeOptionWithPreset() function was split into two in #7288. I tweaked the types to make it work as a single function again. Easy change and it helps to ship tiny bit less code.

Test plan

The logic was covered by tests. All these should pass.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SimenB SimenB merged commit 2b04388 into jestjs:main Aug 30, 2022
@mrazauskas mrazauskas deleted the refactor-mergeOptionWithPreset branch August 30, 2022 08:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants