Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak regex used in e2e tests #13129

Merged
merged 2 commits into from
Aug 22, 2022
Merged

chore: tweak regex used in e2e tests #13129

merged 2 commits into from
Aug 22, 2022

Conversation

Biki-das
Copy link
Contributor

Just added the u flag in the regex as it helps in correct working of regex character ranges

@Biki-das
Copy link
Contributor Author

@SimenB please review, idk why my PR's are being ignored?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

e2e/Utils.ts Outdated Show resolved Hide resolved
@SimenB SimenB changed the title chore:-Added u flag in regex chore: tweak regex used in e2e tests Aug 22, 2022
@SimenB SimenB merged commit ae2bed7 into jestjs:main Aug 22, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants