Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workerIdleMemoryLimit to support worker recycling in the event of node >16.11.0 memory leaks #13056

Merged
merged 51 commits into from
Aug 5, 2022
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
3e4c26b
feat: process recycling
phawxby Jul 22, 2022
833e429
chore: changelog
phawxby Jul 22, 2022
7da8127
chore: remove temp files
phawxby Jul 22, 2022
40a23cf
test: more complete functional testing
phawxby Jul 25, 2022
1961d65
docs: update docs for PR review
phawxby Jul 25, 2022
d7f292f
chore: try this test config
phawxby Jul 25, 2022
8bfcd74
chore: linting
phawxby Jul 25, 2022
fd1be6f
feat: add improved error checking and promise handling
phawxby Jul 25, 2022
233477e
chore: add facebook header
phawxby Jul 25, 2022
19fb71c
fix: use os spy rather than mock to retain platform functions
phawxby Jul 25, 2022
e2a853d
fix: spying of totalmem
phawxby Jul 25, 2022
ab6554d
chore: add some logging to help debugging
phawxby Jul 25, 2022
207ae05
chore: more debugging
phawxby Jul 25, 2022
c4d2389
chore: more debugging
phawxby Jul 25, 2022
0f5c7bb
chore: check files exist
phawxby Jul 25, 2022
d35e4b9
chore: try as a specific js import
phawxby Jul 25, 2022
daee499
chore: try this
phawxby Jul 26, 2022
fd96e78
chore: remove debugging and cleanup
phawxby Jul 26, 2022
576ca63
chore: debug failing test
phawxby Jul 26, 2022
491b16c
fix: windows tests
phawxby Jul 26, 2022
479c123
chore: use verbose output to help
phawxby Jul 26, 2022
ad238f2
Merge branch 'process-recycling' of https://github.com/phawxby/jest i…
phawxby Jul 26, 2022
e3e63e4
chore: disable silent reporter
phawxby Jul 26, 2022
74ce892
chore: temporary change to allow me to see where the tests are stalling
phawxby Jul 27, 2022
8467b8b
chore: set sensible timeout
phawxby Jul 27, 2022
6338419
chore: there's an argument for what i want to do
phawxby Jul 27, 2022
d2acdc3
chore: try this
phawxby Jul 27, 2022
dea2ef2
chore: remove now I have the test order
phawxby Jul 27, 2022
44ff11d
chore: single thread to track down the failing test suite
phawxby Jul 27, 2022
6b3ba00
chore: does skipping this test make the timeouts go away?
phawxby Jul 27, 2022
f208aa9
fix: fatal but not out of memory errors should retry
phawxby Jul 27, 2022
1ca06bc
fix: out of memory test
phawxby Jul 27, 2022
c98dd32
chore: increase timeout
phawxby Jul 27, 2022
c21b48e
chore: debugging output
phawxby Jul 27, 2022
33405a2
Merge branch 'process-recycling' of https://github.com/phawxby/jest i…
phawxby Jul 27, 2022
98f5e82
chore: limit to just failing test and add logging
phawxby Jul 27, 2022
a1b647f
chore: more debugging
phawxby Jul 27, 2022
54dccb3
feat: add stderr concat
phawxby Jul 27, 2022
0f5da7d
chore: back to full tests
phawxby Jul 27, 2022
debf034
test: fix use simple count in case same pid comes up twice
phawxby Jul 27, 2022
4619055
test: add retry and increase timeout
phawxby Jul 27, 2022
da47b50
test: more retries
phawxby Jul 27, 2022
ba00b26
chore: revert changes to jest config
phawxby Jul 27, 2022
019c5d4
feat: port idle usage to thread workers
phawxby Jul 28, 2022
7239650
chore: docs
phawxby Jul 28, 2022
fdb4a66
chore: linting
phawxby Jul 28, 2022
3e3be99
feat: add shorthand idle limit parsing
phawxby Aug 1, 2022
9f9dff1
docs: copyright header
phawxby Aug 1, 2022
43f1054
chore: improve test flake
phawxby Aug 1, 2022
791b7a5
chore: fix typing
phawxby Aug 2, 2022
f3db1cc
chore: pr feedback
phawxby Aug 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove now I have the test order
phawxby committed Jul 27, 2022
commit dea2ef22c45e337ad75ebc20efc738e8d7e55b51
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ jobs:
node-version: << parameters.node-version >>
- node/install-packages: *install
- run:
command: yarn test-ci-partial --shard=$(expr $CIRCLE_NODE_INDEX + 1)/$CIRCLE_NODE_TOTAL --listTests
command: yarn test-ci-partial --shard=$(expr $CIRCLE_NODE_INDEX + 1)/$CIRCLE_NODE_TOTAL
- store_test_results:
path: reports/junit

@@ -43,10 +43,10 @@ jobs:
- node/install-packages: *install
- run:
name: Test
command: JEST_JASMINE=1 yarn test-ci-partial --shard=$(expr $CIRCLE_NODE_INDEX + 1)/$CIRCLE_NODE_TOTAL --listTests --runInBand
command: JEST_JASMINE=1 yarn test-ci-partial --shard=$(expr $CIRCLE_NODE_INDEX + 1)/$CIRCLE_NODE_TOTAL --runInBand
- run:
name: Leak test
command: JEST_JASMINE=1 yarn test-leak --listTests --runInBand
command: JEST_JASMINE=1 yarn test-leak --runInBand
- store_test_results:
path: reports/junit

4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ jobs:
uses: SimenB/github-actions-cpu-cores@v1
- name: run tests
timeout-minutes: 10
run: yarn test-ci-partial:parallel --max-workers ${{ steps.cpu-cores.outputs.count }} --shard=${{ matrix.shard }} --listTests
run: yarn test-ci-partial:parallel --max-workers ${{ steps.cpu-cores.outputs.count }} --shard=${{ matrix.shard }}

test-jasmine:
strategy:
@@ -59,4 +59,4 @@ jobs:
uses: SimenB/github-actions-cpu-cores@v1
- name: run tests using jest-jasmine
timeout-minutes: 10
run: yarn jest-jasmine-ci --max-workers ${{ steps.cpu-cores.outputs.count }} --shard=${{ matrix.shard }} --listTests
run: yarn jest-jasmine-ci --max-workers ${{ steps.cpu-cores.outputs.count }} --shard=${{ matrix.shard }}