Refine babel-plugin-jest-hoist typings #13011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super will not be included in Expression in Babel 8
Do I need to release it? |
|
Thank you for your quick processing! No, our E2E tests are run directly from the github repo. |
|
Good stuff 👍 |
This was referenced Aug 3, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super will not be included in Expression in Babel 8
Summary
Fix potential Babel 8 typing errors: https://github.com/babel/babel/runs/7308856226?check_suite_focus=true#step:10:507
In Babel 8 we will remove
SuperfromExpression: So a MemberExpression's object will beExpression | SuperandisJestObjectshould handleSuperas well. It already supportsSuperbut will need typing updates. I updated typings so that it should work with both Babel 7 and Babel 8.This PR should unblock babel/babel#14750
Test plan
Run
yarn lint