chore(@jest/types): mark collectCoverageOnlyFrom and coveragePathIgnorePatterns options deprecated
#12914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
changed the title
collectCoverageOnlyFrom and coveragePathIgnorePatterns options deprecatedcollectCoverageOnlyFrom and coveragePathIgnorePatterns options deprecated
mrazauskas
commented
Jun 6, 2022
| @@ -157,7 +157,6 @@ For stability and safety reasons, only part of the global configuration keys can | |||
| - [`changedSince`](cli#--changedsince) | |||
| - [`collectCoverage`](configuration#collectcoverage-boolean) | |||
| - [`collectCoverageFrom`](configuration#collectcoveragefrom-array) | |||
| - [`collectCoverageOnlyFrom`](configuration#collectcoverageonlyfrom-array) | |||
|
Closing in favour of #13156 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #1349 (comment)
Reference #1536 (comment)
Related to #7185
Summary
Just thinking out loud. The documentation for
collectCoverageOnlyFromwas removed in #1724. Looking at referenced comments, it seems like there was a plan to remove the option as well after addingcollectCoverageFrom.The regex / glob overlap between
coveragePathIgnorePatternsandcollectCoverageFromwas also questioned in the comments.I am not against any of the options (; Only trying to understand: if they should be documented properly or should be marked
@deprecatedand removed with the next major?Test plan
Green CI.