-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo/punctuation in MockFunctionAPI.md #12887
Conversation
Hi @ChrisCoastal! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
CLA signed. Should be ready for merging. Thanks. |
Thanks! Could you also fix the same |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@mrazauskas Thanks for your review, Tom! I've updated the pull request with commits for MockFunctionAPI.md in |
@SimenB Friendly ping (; This is ready to land. The text with typos was introduced from v28. So all applicable versioned docs are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Small fix typo and comma errors in website documentation jest.fn(implementation?) section in MockFunctionAPI.md.
Test plan
No testing needed:
Simple 'there' -> 'where' typo fix.
No comma after 'if' when it begins a subordinate clause that follows the main clause.