refactor(jest-haste-map): clean up code and types #12795
Conversation
| @@ -444,7 +435,7 @@ export default class HasteMap extends EventEmitter { | |||
| let hasteMap: InternalHasteMap; | |||
| try { | |||
| const read = this._options.resetCache ? this._createEmptyMap : this.read; | |||
| hasteMap = await read.call(this); | |||
There was a problem hiding this comment.
await does nothing here.
| if (dedupMap == null) { | ||
| dedupMap = Object.create(null) as {}; | ||
| if (!dedupMap) { | ||
| dedupMap = Object.create(null) as ModuleMapItem; |
There was a problem hiding this comment.
Just like similar cases above, here dedupMap does not have value yet, so {} is somewhat fine. But the value gets assigned just a couple of lines later. So it makes sense to type it with correct shape already here.
| @@ -466,7 +457,7 @@ export default class HasteMap extends EventEmitter { | |||
| const setModule = (id: string, module: ModuleMetaData) => { | |||
| let moduleMap = map.get(id); | |||
| if (!moduleMap) { | |||
| moduleMap = Object.create(null) as {}; | |||
| moduleMap = Object.create(null) as ModuleMapItem; | |||
There was a problem hiding this comment.
do we need to cast? isn't moduleMap already the correct type?
There was a problem hiding this comment.
Does not work without casting. It needs some type, because Object.create() returns any.
| forceInBand: boolean; | ||
| }): JestWorkerFarm<HasteWorker> | HasteWorker { | ||
| private _getWorker( | ||
| options = {forceInBand: false}, |
There was a problem hiding this comment.
The idea was to have default value. options object always has some value, so there is no need for options && check later.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Split from #12680
Summary
While pushing forward with #12680, I started noticing few details which can be cleaned up in
jest-haste-map. Few initial values, nullish coalescing and some TS bits.Test plan
Green CI.