fix(expect-utils): Fix deep equality of ImmutableJS Lists

[romellem]

Summary

Fixes #12752

Test plan

I could add a test case for iterableEquality, but I'd need to introduce immutable as a dev dependency. Let me know if you'd like to. Otherwise, this relies on the fact that immutable's List implements a similar API to native Set objects, importantly, .has().

[facebook-github-bot]

Hi @romellem!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SimenB]

I could add a test case for iterableEquality, but I'd need to introduce immutable as a dev dependency. Let me know if you'd like to.

Yes please, a dev dep is perfectly fine! (we already have one in pretty-format 🙂 )

[SimenB]

Seems this broke some other tests we have, actually

[romellem]

Thanks, I'll add the new tests and look at the errors on the existing tests a little later on.

[romellem]

Didn't read the logic carefully enough for Sets, it isn't checking order (which makes sense). So instead we don't do the entries check if the objects are Lists.

[SimenB]

seems reasonable, thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.