fix: set testEnvironment to jsdom in react native example

[F3n67u]

Summary

Test plan

[mrazauskas]

Just tried this trick locally and it is fixing the issue I was mentioning in #12558 (comment). Let’s see what CI thinks.

Ah! CircleCI passed. Well done @F3n67u!

[F3n67u]

Interesting! Just tried this trick locally and it is fixing the issue I was mentioning in #12558 (comment). Let’s see what CI thinks.

@mrazauskas It's caused by #12553.

[F3n67u]

I set testEnvironment to jsdom when testing react-native so that react native example will not be affected by jest-environment-node. what do you think? @mrazauskas

[mrazauskas]

I set testEnvironment to jsdom when testing react-native

This also solves the problem. I just think wouldn’t it be better idea to add it to react-native preset? Hm.. For reason the preset sets testEnvironment: 'node'. Hard to say why. I have zero experience with React and React Native.

[F3n67u]

I just think wouldn’t it be better idea to add it to react-native preset?

@mrazauskas I agree with you. I think it would be better to set testEnvironment: 'node' to react native preset if the jest-environment-jsdom is more reasonable to react native app, instead of just overriding testEnvironment in our example.

I haven't any experience with react-native either. I will spend some time investigating.

[F3n67u]

@SimenB created the react-native preset. do you have any advice here?

[SimenB]

Thankfully, all I did was move it from json to js 🙂

facebook/react-native#22972

What they should do is create their own test environment rather than use the built-in node or jsdom ones... It's neither in practice. But I doubt that's going to happen.

The change in this PR should be made in the preset though, not in the example in this repo.

[F3n67u]

@SimenB So your advice is to file a pr to change testEnviroment to jsdom in the preset, right?

[SimenB]

Yep!

[F3n67u]

Yep!

I will do it! thanks for your advice.

[SimenB]

No idea if they'll accept it - as mentioned neither node or jsdom is correct for them. We can land the PR here in the meantime if it unlocks something (I'm on vacation this week, so haven't looked into anything)

[F3n67u]

No idea if they'll accept it - as mentioned neither node or jsdom is correct for them. We can land the PR here in the meantime if it unlocks something (I'm on vacation this week, so haven't looked into anything)

I think it's a good idea. The broken ci make our contributor confused. we could merge this pr first. Sorry to disturb your vacation time.

[mrazauskas]

@F3n67u It also might be good idea to send a PR to react-native which would bump Jest to next. If MessageChannel was already included in latest alpha release, this could potentially surface some problem on their side.

[mrazauskas]

By the way, it might be that the issue is already fix on React side. See facebook/react#20756. The bug was inside scheduler package. For now it is released as scheduler@next. All is good. Just to wait for stable release.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.