Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(jest-mock)!: rename and clean up utility types #12435
refactor(jest-mock)!: rename and clean up utility types #12435
Changes from all commits
e19cfab
c4a94dd
d7aaf62
af1038d
3f27f2b
f004e7c
95b149f
061b275
e409ad8
7cd40aa
2866d1c
3a7081b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly these don’t work with
unknown
. Type tests are failing. Assignably should be the reason: "any
andunknown
are the same in terms of what is assignable to them, different in thatunknown
is not assignable to anything exceptany
. Also TS is usingany
in similar util types: https://github.com/microsoft/TypeScript/blob/78818e03908a6cca779fec1355744ed60bda2c63/lib/lib.es5.d.ts#L1526There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use
CallableFunction
from ts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea. I was checking if
CallableFunction
(alsoNewableFunction
) could work here, but it didn’t. Seems like these are great types forbind
,apply
, but what we need here is just to check that type has callable signature. That’s why addingLike
looked good, but it also might be good idea to name them simply:Callable
andConstructable
. What you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative names:
ConstructorKeys<T>
,MethodKeys<T>
,PropertyKeys<T>
. The first one did not sound. IncludingLike
is somewhat more clear. These utils return a tuple of keys with respectively constructor-like, method-like or property-like values of objectT
.