Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(haste-map): default to node crawl if watchman is not enabled #12320

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 7, 2022

Summary

Toggling option from #11264.

On my machine the node crawl is even faster than watchman for --list-tests, while both beat find into dust.

This branch:

$  hyperfine 'yarn jest --list-tests' 'yarn jest --list-tests --no-watchman'
Benchmark 1: yarn jest --list-tests
  Time (mean ± σ):      2.921 s ±  0.750 s    [User: 3.143 s, System: 0.549 s]
  Range (min … max):    2.261 s …  4.519 s    10 runs

Benchmark 2: yarn jest --list-tests --no-watchman
  Time (mean ± σ):      2.197 s ±  0.216 s    [User: 2.367 s, System: 0.414 s]
  Range (min … max):    2.074 s …  2.801 s    10 runs

main:

$ hyperfine 'yarn jest --list-tests --no-watchman'
Benchmark 1: yarn jest --list-tests --no-watchman
  Time (mean ± σ):      3.684 s ±  0.364 s    [User: 2.878 s, System: 1.415 s]
  Range (min … max):    3.225 s …  4.341 s    10 runs

Test plan

Green CI

@codecov-commenter
Copy link

Codecov Report

Merging #12320 (1a2ebd5) into main (762b9b7) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12320      +/-   ##
==========================================
- Coverage   67.25%   67.25%   -0.01%     
==========================================
  Files         330      330              
  Lines       17354    17354              
  Branches     5073     5073              
==========================================
- Hits        11672    11671       -1     
- Misses       5650     5651       +1     
  Partials       32       32              
Impacted Files Coverage Δ
packages/jest-config/src/Defaults.ts 100.00% <ø> (ø)
packages/jest-config/src/ValidConfig.ts 100.00% <ø> (ø)
packages/expect/src/utils.ts 96.09% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762b9b7...1a2ebd5. Read the comment docs.

@SimenB SimenB force-pushed the default-node-crawl branch from 1a2ebd5 to 96331c1 Compare February 9, 2022 08:46
@SimenB SimenB merged commit 4af559a into jestjs:main Feb 9, 2022
@SimenB SimenB deleted the default-node-crawl branch February 9, 2022 10:47
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants