-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add performance global to nodejs environment #12002
Conversation
Hi @SimonSiefke! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
can you fixup the second commit to the first one? |
Sorry, misclicked
That's not an issue as we squash on merge. However, the CLA needs to be signed before we can merge this 🙂 |
Right, same as #12001 (comment). I unfortunately have no idea, hopefully somebody at FB figures it out |
Regarding cla: #12001 (comment) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #12002 +/- ##
==========================================
- Coverage 67.72% 67.71% -0.01%
==========================================
Files 328 328
Lines 16993 16995 +2
Branches 4818 4819 +1
==========================================
+ Hits 11508 11509 +1
- Misses 5452 5453 +1
Partials 33 33
Continue to review full report at Codecov.
|
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #11629
Test plan
before:
after: