-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications for test results #1170
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
abd406f
Add growl notifications
de461c1
Move Growler to Config package
914e67f
Move Growler to Config package
8a4a773
Fixing code according to abc-rule and fix typo in doc
761fc51
Add bigger jest logo for retina displays
4c9fcb8
Use node-notifier for notifications and renamed class and parameter
a17dfca
Replace unicode string with escaped values
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/** | ||
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @flow | ||
*/ | ||
'use strict'; | ||
|
||
import type {AggregatedResult} from 'types/TestResult'; | ||
|
||
const notifier = require('node-notifier'); | ||
const path = require('path'); | ||
const util = require('util'); | ||
|
||
const isDarwin = process.platform === 'darwin'; | ||
|
||
const ICON = '/assets/jest_logo.png'; | ||
const NOTIFICATIONS = { | ||
success: { | ||
title: '%d%% Passed', | ||
message: (isDarwin ? '✅ ' : '') + '%d tests passed', | ||
icon: ICON, | ||
}, | ||
failure: { | ||
title: '%d%% Failed', | ||
message: (isDarwin ? '⛔️ ' : '') + '%d of %d tests failed', | ||
icon: ICON, | ||
}, | ||
}; | ||
|
||
type Notification = { | ||
title: string, | ||
message: string, | ||
icon: string, | ||
}; | ||
|
||
class Notifier { | ||
|
||
static onTestResults(result: AggregatedResult): void { | ||
let info; | ||
let title; | ||
let message; | ||
|
||
if (result.success) { | ||
info = NOTIFICATIONS['success']; | ||
title = util.format(info.title, 100); | ||
message = util.format(info.message, result.numPassedTests); | ||
} else { | ||
info = NOTIFICATIONS['failure']; | ||
title = util.format(info.title, Math.ceil( | ||
(result.numFailedTests / result.numTotalTests) * 100, | ||
)); | ||
message = util.format( | ||
info.message, | ||
result.numFailedTests, | ||
result.numTotalTests, | ||
); | ||
} | ||
const icon = path.join(__dirname, info.icon); | ||
|
||
const notification = { | ||
title, | ||
message, | ||
icon, | ||
}; | ||
|
||
this.trigger(notification); | ||
} | ||
|
||
static trigger(notification: Notification): void { | ||
notifier.notify(notification); | ||
} | ||
} | ||
|
||
module.exports = Notifier; |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do
NOTIFICATIONS.success
.