Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for test results #1170

Merged
merged 7 commits into from
Jun 16, 2016
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/API.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Jest uses Jasmine 2 by default. An introduction to Jasmine 2 can be found
- [`moduleNameMapper` [object<string, string>]](#modulenamemapper-object-string-string)
- [`modulePaths` [array<string>]](#modulepaths-array-string)
- [`modulePathIgnorePatterns` [array<string>]](#modulepathignorepatterns-array-string)
- [`notify` [boolean]](#notify-boolean)
- [`preprocessorIgnorePatterns` [array<string>]](#preprocessorignorepatterns-array-string)
- [`rootDir` [string]](#rootdir-string)
- [`scriptPreprocessor` [string]](#scriptpreprocessor-string)
Expand Down Expand Up @@ -540,6 +541,11 @@ Example:
}
```

### `notify` [boolean]
(default: `false`)

Activates notifications for test results.

### `rootDir` [string]
(default: The root of the directory containing the `package.json` *or* the [`pwd`](http://en.wikipedia.org/wiki/Pwd) if no `package.json` is found)

Expand Down
6 changes: 6 additions & 0 deletions packages/jest-cli/src/cli/args.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ const options = {
),
type: 'boolean',
},
notify: {
description: wrap(
'Activates notifications for test results.'
),
type: 'boolean',
},
watch: {
description: wrap(
'Watch files for changes and rerun tests related to changed files. ' +
Expand Down
3 changes: 2 additions & 1 deletion packages/jest-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"jest-resolve": "^12.1.0",
"jest-runtime": "^12.1.0",
"jest-util": "^12.1.0",
"json-stable-stringify": "^1.0.0"
"json-stable-stringify": "^1.0.0",
"node-notifier": "^4.6.0"
},
"jest": {
"rootDir": "./build",
Expand Down
78 changes: 78 additions & 0 deletions packages/jest-config/src/Notifier.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
/**
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
* @flow
*/
'use strict';

import type {AggregatedResult} from 'types/TestResult';

const notifier = require('node-notifier');
const path = require('path');
const util = require('util');

const isDarwin = process.platform === 'darwin';

const ICON = '/assets/jest_logo.png';
const NOTIFICATIONS = {
success: {
title: '%d%% Passed',
message: (isDarwin ? '✅ ' : '') + '%d tests passed',
icon: ICON,
},
failure: {
title: '%d%% Failed',
message: (isDarwin ? '⛔️ ' : '') + '%d of %d tests failed',
icon: ICON,
},
};

type Notification = {
title: string,
message: string,
icon: string,
};

class Notifier {

static onTestResults(result: AggregatedResult): void {
let info;
let title;
let message;

if (result.success) {
info = NOTIFICATIONS['success'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do NOTIFICATIONS.success.

title = util.format(info.title, 100);
message = util.format(info.message, result.numPassedTests);
} else {
info = NOTIFICATIONS['failure'];
title = util.format(info.title, Math.ceil(
(result.numFailedTests / result.numTotalTests) * 100,
));
message = util.format(
info.message,
result.numFailedTests,
result.numTotalTests,
);
}
const icon = path.join(__dirname, info.icon);

const notification = {
title,
message,
icon,
};

this.trigger(notification);
}

static trigger(notification: Notification): void {
notifier.notify(notification);
}
}

module.exports = Notifier;
Binary file added packages/jest-config/src/assets/jest_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/jest-config/src/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ module.exports = ({
modulePathIgnorePatterns: [],
noHighlight: false,
noStackTrace: false,
notify: false,
testEnvData: {},
testEnvironment: 'jest-environment-jsdom',
testPathDirs: ['<rootDir>'],
Expand Down
1 change: 1 addition & 0 deletions packages/jest-config/src/normalize.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ function normalize(config, argv) {
case 'name':
case 'noHighlight':
case 'noStackTrace':
case 'notify':
case 'persistModuleRegistryBetweenSpecs':
case 'rootDir':
case 'updateSnapshot':
Expand Down
6 changes: 6 additions & 0 deletions packages/jest-config/src/reporters/DefaultTestReporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import type {Process} from 'types/Process';

const chalk = require('chalk');
const formatFailureMessage = require('jest-util').formatFailureMessage;
const Notifier = require('../Notifier');
const path = require('path');
const VerboseLogger = require('./VerboseLogger');

Expand Down Expand Up @@ -183,6 +184,11 @@ class DefaultTestReporter {

this._printSummary(aggregatedResults);
this.log(results);

if (config.notify) {
Notifier.onTestResults(aggregatedResults);
}

return snapshotFailure ? false : aggregatedResults.success;
}

Expand Down
4 changes: 4 additions & 0 deletions packages/jest-config/src/setFromArgv.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ function setFromArgv(config, argv) {
config.verbose = argv.verbose;
}

if (argv.notify) {
config.notify = argv.notify;
}

if (argv.bail) {
config.bail = argv.bail;
}
Expand Down
1 change: 1 addition & 0 deletions scripts/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ runCommands('node bin/jest.js --runInBand', 'packages/jest-cli');
runCommands('node bin/jest.js --runInBand --logHeapUsage', 'packages/jest-cli');
runCommands('node bin/jest.js --json', 'packages/jest-cli');
runCommands('node bin/jest.js --verbose', 'packages/jest-cli');
runCommands('node bin/jest.js --notify', 'packages/jest-cli');

examples.forEach(runExampleTests);

Expand Down
1 change: 1 addition & 0 deletions types/Config.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ type BaseConfig = {
modulePathIgnorePatterns: Array<string>,
noHighlight: boolean,
noStackTrace: boolean,
notify: boolean,
testEnvData: {},
testEnvironment: string,
testPathDirs: Array<Path>,
Expand Down