Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flush animation frames every 16ms when using legacy timers #11567

Merged
merged 5 commits into from
Jun 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Features

- `[jest-fake-timers]` Flush callbacks scheduled with `requestAnimationFrame` every 16ms when using legacy timers. ([#11523](https://github.com/facebook/jest/pull/11567))

### Fixes

- `[jest-reporter]` Allow `node-notifier@10` as peer dependency ([#11523](https://github.com/facebook/jest/pull/11523))
Expand Down
26 changes: 26 additions & 0 deletions e2e/fake-time/legacy/requestAnimationFrame/__tests__/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/* global requestAnimationFrame */

'use strict';

test('requestAnimationFrame', () => {
jest.useFakeTimers('legacy');
let frameTimestamp = -1;
requestAnimationFrame(timestamp => {
frameTimestamp = timestamp;
});

jest.advanceTimersByTime(15);

expect(frameTimestamp).toBe(-1);

jest.advanceTimersByTime(1);

expect(frameTimestamp).toBeGreaterThan(15);
});
5 changes: 5 additions & 0 deletions e2e/fake-time/legacy/requestAnimationFrame/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"jest": {
"testEnvironment": "jsdom"
}
}
26 changes: 26 additions & 0 deletions e2e/fake-time/modern/requestAnimationFrame/__tests__/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/* global requestAnimationFrame */

'use strict';

test('requestAnimationFrame', () => {
jest.useFakeTimers('modern');
let frameTimestamp = -1;
requestAnimationFrame(timestamp => {
frameTimestamp = timestamp;
});

jest.advanceTimersByTime(15);

expect(frameTimestamp).toBe(-1);

jest.advanceTimersByTime(1);

expect(frameTimestamp).toBeGreaterThan(15);
});
5 changes: 5 additions & 0 deletions e2e/fake-time/modern/requestAnimationFrame/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"jest": {
"testEnvironment": "jsdom"
}
}
Loading