Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test verifying PnP works #11513

Merged
merged 8 commits into from
Jun 3, 2021
Merged

chore: add test verifying PnP works #11513

merged 8 commits into from
Jun 3, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jun 3, 2021

Summary

From #11493 - I'm unable to make this test work properly...

Test plan

Green CI? 😀

@merceyz
Copy link
Contributor

merceyz commented Jun 3, 2021

I cloned the repo and ran the test and something interesting is going on... it spawned 1600 processes before the system ran out of resources, froze, and had to be force restarted. Is that what you meant by it doesn't work?

@codecov-commenter
Copy link

Codecov Report

Merging #11513 (de9e27e) into master (d6fb0d8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11513   +/-   ##
=======================================
  Coverage   68.93%   68.94%           
=======================================
  Files         312      312           
  Lines       16314    16314           
  Branches     4726     4726           
=======================================
+ Hits        11246    11247    +1     
+ Misses       5040     5039    -1     
  Partials       28       28           
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.13% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fb0d8...de9e27e. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Jun 3, 2021

Auch! Sorry about that 😬 Probably the require('jest/bin/jest') thing at the bottom, I haven't actually tested that one, just had it lying around locally...

@SimenB
Copy link
Member Author

SimenB commented Jun 3, 2021

Pushed a commit which fails due to missing binary. Changing the link to portal and uncommenting the resolutions gives another error. I'm not sure what the best approach is?

@merceyz
Copy link
Contributor

merceyz commented Jun 3, 2021

Probably the require('jest/bin/jest') thing at the bottom

It's interesting because going to the temp directory and running yarn node -e "require('jest/bin/jest')" manually works just fine

scripts/verifyPnP.js Outdated Show resolved Hide resolved
@SimenB
Copy link
Member Author

SimenB commented Jun 3, 2021

I've also verified the test fails with #11493 reverted. Thanks for the help @merceyz!

@SimenB SimenB marked this pull request as ready for review June 3, 2021 10:04
@SimenB SimenB merged commit b931b3c into jestjs:master Jun 3, 2021
@SimenB SimenB deleted the pnp-test branch June 3, 2021 11:30
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants