-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add test verifying PnP works #11513
Conversation
I cloned the repo and ran the test and something interesting is going on... it spawned 1600 processes before the system ran out of resources, froze, and had to be force restarted. Is that what you meant by it doesn't work? |
Codecov Report
@@ Coverage Diff @@
## master #11513 +/- ##
=======================================
Coverage 68.93% 68.94%
=======================================
Files 312 312
Lines 16314 16314
Branches 4726 4726
=======================================
+ Hits 11246 11247 +1
+ Misses 5040 5039 -1
Partials 28 28
Continue to review full report at Codecov.
|
Auch! Sorry about that 😬 Probably the |
Pushed a commit which fails due to missing binary. Changing the |
It's interesting because going to the temp directory and running |
Co-authored-by: Kristoffer K. <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
From #11493 - I'm unable to make this test work properly...
Test plan
Green CI? 😀