Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-core): Add support for testSequencer written in ESM #11207

Merged
merged 5 commits into from
Mar 20, 2021

Conversation

WeiAnAn
Copy link
Contributor

@WeiAnAn WeiAnAn commented Mar 17, 2021

Summary

Related to #11167

Add support for testSequencer written in ESM.

Use requireOrImportModule to load testSequencer

Test plan

e2e test

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@SimenB
Copy link
Member

SimenB commented Mar 17, 2021

You need to skip the test on node 10. See how other esm tests does it

@WeiAnAn
Copy link
Contributor Author

WeiAnAn commented Mar 17, 2021

You need to skip the test on node 10. See how other esm tests does it

Done it!
Wait CI pass 🎉

@SimenB SimenB merged commit 2d96526 into jestjs:master Mar 20, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants