Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added GithubActionsReporter #10741

Closed

Conversation

mariusGundersen
Copy link
Contributor

Summary

This is based on recommendation and work done in stefanbuck/jest-matcher#2

Test plan

Testing is not implemented yet, this is just a placeholder pr

@facebook-github-bot
Copy link
Contributor

Hi @mariusGundersen!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ockham
Copy link
Contributor

ockham commented Apr 13, 2021

👋 Any news on this? This would be a great addition to Jest 🎉

@mariusGundersen, are you still working on this? Seems like there are a couple of style issues that have been flagged by the corresponding GH Action. It'd be great if these could be fixed and the PR could be set to 'Ready for review' 😊 🙏

@SimenB
Copy link
Member

SimenB commented Apr 14, 2021

I think it should be enough to run eslint to fix those. I'm mainly waiting for tests 🙂

@ockham
Copy link
Contributor

ockham commented Apr 20, 2021

I think it should be enough to run eslint to fix those. I'm mainly waiting for tests 🙂

I've created a (very minimal) test case that can hopefully serve as a baseline for further discussion: #11320

@SimenB
Copy link
Member

SimenB commented Apr 5, 2022

@github-actions
Copy link

github-actions bot commented May 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants