Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate testURL as CLI option #10595

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix: validate testURL as CLI option #10595

merged 1 commit into from
Oct 8, 2020
+15 −0

Conversation

victorphoenix3
Copy link
Contributor

Resolves #8889
Currently running jest --testURL "https://localhost" fails with --testURL being treated as Unrecognized CLI Parameter.

@victorphoenix3 victorphoenix3 force-pushed the first branch 3 times, most recently from d5f5cb5 to 5e966da Compare October 6, 2020 00:51
@victorphoenix3
Copy link
Contributor Author

Hi @SimenB . The PR is ready for review!

@mkcode
Copy link

mkcode commented Oct 8, 2020

LGTM

@thymikee
Copy link
Collaborator

thymikee commented Oct 8, 2020

How about renaming it to testUrl so it's consistent with others?

SimenB
SimenB approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Oct 8, 2020

We squash merge, so multiple commits doesn't matter. They don't hurt either of course, but you don't have to worry too much about the commit history of your PRs 🙂

@SimenB SimenB changed the title Validate testURL as CLI option fix: validate testURL as CLI option Oct 8, 2020
@SimenB SimenB merged commit b0c16bd into jestjs:master Oct 8, 2020
@SimenB
Copy link
Member

SimenB commented Oct 8, 2020

Thanks @victorphoenix3!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using --testURL as a CLI option results in Unrecognized CLI Parameter"
6 participants
@victorphoenix3 @mkcode @thymikee @SimenB @snitin315 @facebook-github-bot