Exploit the second console.dir argument
#10182
Conversation
* fixes jestjs#10176 * repeats behaviour of the node.js Console class https://github.com/nodejs/node/blob/9918bdf5cb07f58d230522244a372cbb1b510956/lib/internal/console/constructor.js
| const deepObject = {1: {2: {3: {4: {5: {6: 'value'}}}}}}; | ||
| _console.dir(deepObject, {depth: 6}); | ||
|
|
||
| expect(_stdout).toMatch('value'); |
There was a problem hiding this comment.
maybe this should be a snapshot so we can see the entire structure? same for the test below
There was a problem hiding this comment.
util.inspect implementation may differ from version to version as described in node.js documentation, but if that's ok for you, I'll introduce expect(deepObject).toMatchInlineSnapshot().
There was a problem hiding this comment.
Jest's output in this case shouldn't vary though, should it?
There was a problem hiding this comment.
Could you, please, rephrase the sentence? Not sure I properly understand you.
util.format may also differ from version to version, thus Jest's console.log output may vary from version to version. Same with console.dir.
Will Node.js core developers decide to change util.inspect for deep objects? Who knows, maybe they will add/remove extra spaces between colons. But value will always be in the output.
I'm not a core developer, so just say what to do, I'll do it.
|
I'm sorry this was forgot about :/ - #10638 was just opened and is up to date on master. You're still a commit author in there for when that is merged :) |
|
@jeysal then I'll close this PR. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #10176. Now
console.dirrepeats the behavior of the Node.js Console class.Test plan