Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-circus is missing dependency on jest-runtime #9600

Closed
jimmydief opened this issue Feb 19, 2020 · 1 comment Β· Fixed by #9717
Closed

jest-circus is missing dependency on jest-runtime #9600

jimmydief opened this issue Feb 19, 2020 · 1 comment Β· Fixed by #9717

Comments

@jimmydief
Copy link
Contributor

jimmydief commented Feb 19, 2020

πŸ› Bug Report

After upgrading Jest to 25.1.0, I noticed an issue with jest-circus having a dev-only dependency on jest-runtime.

  ● Test suite failed to run

    Cannot find module 'jest-runtime'

      at Object.<anonymous> (node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:5:43)

jest-runtime is indeed referenced within jestAdapter.ts here:

https://github.com/facebook/jest/blob/2ee214d47f8bbd7fec1b6b4051a2e265136c79a5/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts#L12

It's referenced as a dev dependency here:

https://github.com/facebook/jest/blob/2ee214d47f8bbd7fec1b6b4051a2e265136c79a5/packages/jest-circus/package.json#L38

To Reproduce

I can create a reproduction repo if necessary, seems like this can be solved fairly easily by just moving the dependency though.

Expected behavior

No uncaught exceptions from within the test framework.

Link to repl or repo (highly encouraged)

See note above.

envinfo

System:
    OS: macOS 10.15.3
    CPU: (4) x64 Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
  Binaries:
    Node: 8.11.1 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 5.6.0 - /usr/local/bin/npm
  npmPackages:
    jest: 25.1.0 => 25.1.0
@jimmydief jimmydief changed the title jest-cli & and jest-circus are missing dependencies jest-circus is missing dependency on jest-runtime Feb 24, 2020
jimmydief added a commit to jimmydief/jest that referenced this issue Mar 27, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant