Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable being referenced in custom-matchers-api section's code example #8581

Closed
tohjustin opened this issue Jun 19, 2019 · 1 comment · Fixed by #8582
Closed

Undefined variable being referenced in custom-matchers-api section's code example #8581

tohjustin opened this issue Jun 19, 2019 · 1 comment · Fixed by #8582
Labels
Bug Report Needs Triage

Comments

@tohjustin
Copy link
Contributor

tohjustin commented Jun 19, 2019 •
edited
Loading

🐛 Bug Report

The code example in the documentation's custom-matchers-api (this.utils) section referenced a non-existent variable diffString.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the custom-matchers-api (this.utils) section of the documentation website.

Expected behavior

The codebase seems have a convention of using diffString to contain the diff() result, would be a good idea to update the code example to consistently use diffString instead (i.e. replace all instances of difference to diffString).
tohjustin added a commit to tohjustin/jest that referenced this issue Jun 19, 2019
@tohjustin
docs: Fix variable name in custom-matcher-api code example (jestjs#8581)
94af4c3
@tohjustin tohjustin mentioned this issue Jun 19, 2019
Merged
tohjustin added a commit to tohjustin/jest that referenced this issue Jun 19, 2019
@tohjustin
docs: Fix variable name in custom-matcher-api code example (jestjs#8581)
932335c
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Report Needs Triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix variable name in custom-matcher-api code example tohjustin/jest
1 participant
@tohjustin