beforeAll: not skipped within describe.skip (again)

[Rendez]

🐛 Bug Report

beforeAll functions are run even when defined inside of a describe.skip block.

To Reproduce

• Define a describe.skip block.
• Define a beforeAll inside the describe.skip block.
  Do something within the beforeAll function to confirm that it does or does not get run (e.g. add a console.log statement, set some flag, etc.).

Expected behavior

The function registered by the beforeAll is never executed.

This bug was reported in #6166 and fixed in #6234, but it reappeared.

Link to repl or repo (highly encouraged)

https://codesandbox.io/s/74xr2vrpnj (use the Tests tab)

Jest runs via react-scripts at this version: https://github.com/facebook/create-react-app/blob/v2.1.8/package.json#L28

[weworkwithzoh]

I too am seeing this.

[holograph]

Yep, experiencing this too, it's pretty consistent (full disclosure: I work with @weworkwithzoh)

[EKoetsjarjan]

beforeAll() , always runs
$ jest -v
24.8.0
upvote please

[EKoetsjarjan]

Hi, I have created this workaround, by adding a additioinal flag

is it possible to get the skipped flag from the jest context?

describe.skip('Testing confirmations', () => {
   var skip = false //bug beforeAll is always run even when skipped, do it this way  
   beforeAll(async () => {
             if(skip)return
       ....
       });

  test('Testing ', () => {
        /////.....
  });

});

[WestonThayer]

This is especially painful when using Jest for functional tests that do some heavy lifting in beforeAll. For example, writing some Selenium tests that work with a service like Browserstack. In beforeAll, you'd usually create a new WebDriver that's connected to their service, which takes a while. I'm forced to comment out tests I don't wan to run, otherwise they slow down my workflow significantly.

[WestonThayer]

If anyone is looking for an easy substitute for .skip, just create a new dummy function at the top of your file, like:

const describeSkip = () => {}

Then append Skip instead of .skip.

[ihorfito]

up

[rogeliog]

Quick question, does running it with jest-circus fixes the issue?

[holograph]

It did for us, yes.

…

On Mon, 2 Dec 2019 at 20:08 Rogelio Guzman ***@***.***> wrote: Quick question, does running it with (jest-circus)[ https://github.com/facebook/jest/tree/master/packages/jest-circus] fixes the issue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8379>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIQFYECHQAHUVPY6EZEOXDQWVFK5ANCNFSM4HIN42TQ> .

[cotispear]

If anyone is looking for an easy substitute for .skip, just create a new dummy function at the top of your file, like:

const describeSkip = () => {}

Then append Skip instead of .skip.

Unfortunately we have an entire test suite that we want to be conditionally skipped. This "works", but Jest fails with:

Your test suite must contain at least one test

So we have to include a dummy describe(). 😢

[enriqu3l]

Any update here?

As far as I know, this was a previous bug that appeared again.

Currently I am using the workaround of adding if(skip)return inside of beforeAll.

[EKoetsjarjan]

Any update here?

As far as I know, this was a previous bug that appeared again.

Currently I am using the workaround of adding if(skip)return inside of beforeAll.

me too

[brianseeders]

+1 seeing the same issue on 25.1.0, MacOS, node 12.16.1.

Started seeing failed tests in CI in our junit reports for skipped tests, and it turned out to be this issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.