[jest-circus] throw if beforeAll or afterAll hooks defined in empty describe block

[aaronabramov]

right now Jasmine would run beforeAll and afterAll hooks even if there are no tests. e.g.

beforeAll(() => console.log('1');
afterAll(() => console.log('2');
test.skip('test', () => {});

will print

>1
>2

// ...
describe('something', () => {
  beforeAll(() => console.log(1);
  afterAll(() => console.log('2');
  // no `test` or `it` in this describe
});

will do the same.

because there's no point in doing so we should disallow it and throw an error

the fix should be inside jest-circus package
to run jest tests using jest-circus run JEST_CIRCUS=1 ./jest

[captbaritone]

I'm looking at this.

[aaronabramov]

sweet! let's reuse unhandledErrors state key for that, so the test still runs, but later fails the suite

[aaronabramov]

(see errors in afterAll hook implementation)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.