-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest 23 throws errors on test
cases without a callback defined
#6256
Comments
This is by design, see #5558. You can do |
That is a terrible design. You have thrown a wrench in anyone who implements Test-Driven Development (TDD). Please reopen this bug as a feature request to make this configurable. |
@goyney the change seems a bit over the top (ensuring the the second arg was |
Had to change the way pending tests are done (jestjs/jest#6256) All snapshot were updated due to whitespace (except for chart-detail)
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🐛 Bug Report
The latest version of Jest (23) now throws errors on test statements without a callback.
To Reproduce
Create a test file with the following in it:
Expected behavior
Tests without a callback are marked as "pending" and do not throw errors.
We very, very commonly write out test cases before implementing the tests. These serve as reminders, or as a plan, of what the functional code we are going to write should actually do. With the latest changes in Jest 23, all of these throw errors now and our test suite fails.
Please revert this change or make this behavior toggleable.
The text was updated successfully, but these errors were encountered: