Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce the case style for filenames #3890

Closed
aaronabramov opened this issue Jun 23, 2017 · 5 comments
Closed

Enforce the case style for filenames #3890

aaronabramov opened this issue Jun 23, 2017 · 5 comments

Comments

@aaronabramov
Copy link
Contributor

followup to #3771 and #3798

we need to enforce this naming convention.
We can probably either use an eslint plugin (this will only cover .js files)
or write an actual test that will traverse the directory tree and make sure files are named properly

@thymikee
Copy link
Collaborator

I'm for eslint plugin

@sumnerevans
Copy link

Hello @aaronabramov, @thymikee, @anilreddykatta. I was looking through the issues for "Good First Tasks" and came across this one. I see that a significant amount of work has already been done.

@anilreddykatta, I saw your comment on #3920 and you mentioned that you were going to work on the exempted files individually. I don't want to duplicate effort but I'd like to jump in on this if there is still work to do. What directories still have files that need to be renamed?

@aaronabramov
Copy link
Contributor Author

@sumnerevans yes, there's a still a few files left that need to be renamed. It would be awesome if you could coordinate the efforts!
i'm closing this issues, since we already enforced naming for the majority of files

@sumnerevans
Copy link

@anilreddykatta, have you started renaming the examples?
@aaronabramov, do the examples even need to be renamed?

tushardhole pushed a commit to tushardhole/jest that referenced this issue Aug 21, 2017
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants