-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: mocking of getters/setters on automatically mocked classes (#13398)
- Loading branch information
1 parent
30da552
commit f126336
Showing
9 changed files
with
966 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
packages/jest-mock/src/__tests__/__fixtures__/SuperTestClass.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
export class SuperTestClass { | ||
static staticTestProperty = 'staticTestProperty'; | ||
|
||
static get staticTestAccessor(): string { | ||
return 'staticTestAccessor'; | ||
} | ||
|
||
static set staticTestAccessor(_x: string) { | ||
return; | ||
} | ||
|
||
static staticTestMethod(): string { | ||
return 'staticTestMethod'; | ||
} | ||
|
||
testProperty = 'testProperty'; | ||
|
||
get testAccessor(): string { | ||
return 'testAccessor'; | ||
} | ||
set testAccessor(_x: string) { | ||
return; | ||
} | ||
|
||
testMethod(): string { | ||
return 'testMethod'; | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
packages/jest-mock/src/__tests__/__fixtures__/TestClass.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import {SuperTestClass} from './SuperTestClass'; | ||
|
||
export default class TestClass extends SuperTestClass {} |
54 changes: 54 additions & 0 deletions
54
packages/jest-mock/src/__tests__/__fixtures__/class-mocks-types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
export default class SuperTestClass { | ||
static staticTestProperty = 'staticTestProperty'; | ||
|
||
static get staticTestAccessor(): string { | ||
return 'staticTestAccessor'; | ||
} | ||
|
||
static set staticTestAccessor(_x: string) { | ||
return; | ||
} | ||
|
||
static staticTestMethod(): string { | ||
return 'staticTestMethod'; | ||
} | ||
|
||
static get(): string { | ||
return 'get'; | ||
} | ||
|
||
static set(): string { | ||
return 'set'; | ||
} | ||
|
||
testProperty = 'testProperty'; | ||
|
||
get testAccessor(): string { | ||
return 'testAccessor'; | ||
} | ||
set testAccessor(_x: string) { | ||
return; | ||
} | ||
|
||
testMethod(): string { | ||
return 'testMethod'; | ||
} | ||
|
||
get(): string { | ||
return 'get'; | ||
} | ||
|
||
set(): string { | ||
return 'set'; | ||
} | ||
} | ||
|
||
export class TestClass extends SuperTestClass {} |
130 changes: 130 additions & 0 deletions
130
packages/jest-mock/src/__tests__/class-mocks-dual-import.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import {SuperTestClass} from './__fixtures__/SuperTestClass'; | ||
import TestClass from './__fixtures__/TestClass'; | ||
jest.mock('./__fixtures__/SuperTestClass'); | ||
jest.mock('./__fixtures__/TestClass'); | ||
|
||
describe('Testing the mocking of a class hierarchy defined in multiple imports', () => { | ||
it('can call an instance method - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(SuperTestClass.prototype, 'testMethod') | ||
.mockImplementation(() => { | ||
return 'mockTestMethod'; | ||
}); | ||
const testClassInstance = new SuperTestClass(); | ||
expect(testClassInstance.testMethod()).toBe('mockTestMethod'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
|
||
mockTestMethod.mockClear(); | ||
}); | ||
|
||
it('can call a superclass instance method - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(TestClass.prototype, 'testMethod') | ||
.mockImplementation(() => { | ||
return 'mockTestMethod'; | ||
}); | ||
const testClassInstance = new TestClass(); | ||
expect(testClassInstance.testMethod()).toBe('mockTestMethod'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('can read a value from an instance getter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(SuperTestClass.prototype, 'testAccessor', 'get') | ||
.mockImplementation(() => { | ||
return 'mockTestAccessor'; | ||
}); | ||
const testClassInstance = new SuperTestClass(); | ||
expect(testClassInstance.testAccessor).toBe('mockTestAccessor'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
|
||
mockTestMethod.mockClear(); | ||
}); | ||
|
||
it('can read a value from a superclass instance getter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(TestClass.prototype, 'testAccessor', 'get') | ||
.mockImplementation(() => { | ||
return 'mockTestAccessor'; | ||
}); | ||
const testClassInstance = new TestClass(); | ||
expect(testClassInstance.testAccessor).toBe('mockTestAccessor'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('can write a value to an instance setter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(SuperTestClass.prototype, 'testAccessor', 'set') | ||
.mockImplementation((_x: string) => { | ||
return () => {}; | ||
}); | ||
const testClassInstance = new SuperTestClass(); | ||
testClassInstance.testAccessor = ''; | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
|
||
mockTestMethod.mockClear(); | ||
}); | ||
|
||
it('can write a value to a superclass instance setter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(TestClass.prototype, 'testAccessor', 'set') | ||
.mockImplementation((_x: string) => { | ||
return () => {}; | ||
}); | ||
const testClassInstance = new TestClass(); | ||
testClassInstance.testAccessor = ''; | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('can read a value from a static getter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(SuperTestClass, 'staticTestAccessor', 'get') | ||
.mockImplementation(() => { | ||
return 'mockStaticTestAccessor'; | ||
}); | ||
expect(SuperTestClass.staticTestAccessor).toBe('mockStaticTestAccessor'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
|
||
mockTestMethod.mockClear(); | ||
}); | ||
|
||
it('can read a value from a superclass static getter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(TestClass, 'staticTestAccessor', 'get') | ||
.mockImplementation(() => { | ||
return 'mockStaticTestAccessor'; | ||
}); | ||
expect(TestClass.staticTestAccessor).toBe('mockStaticTestAccessor'); | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('can write a value to a static setter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(SuperTestClass, 'staticTestAccessor', 'set') | ||
.mockImplementation((_x: string) => { | ||
return () => {}; | ||
}); | ||
SuperTestClass.staticTestAccessor = ''; | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
|
||
mockTestMethod.mockClear(); | ||
}); | ||
|
||
it('can write a value to a superclass static setter - Auto-mocked class', () => { | ||
const mockTestMethod = jest | ||
.spyOn(TestClass, 'staticTestAccessor', 'set') | ||
.mockImplementation((_x: string) => { | ||
return () => {}; | ||
}); | ||
TestClass.staticTestAccessor = ''; | ||
expect(mockTestMethod).toHaveBeenCalledTimes(1); | ||
}); | ||
}); |
Oops, something went wrong.