Skip to content

Commit

Permalink
Coverage option for editor support (#5836)
Browse files Browse the repository at this point in the history
When using the Jest extension in vscode, running coverage is often slow so it would be nice to be able to turn it on and off as needed.

Add a coverage option to the runner.
  • Loading branch information
Nathan L Smith authored and cpojer committed Mar 28, 2018
1 parent f099621 commit bce54cd
Show file tree
Hide file tree
Showing 5 changed files with 49 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Features

* `[jest-editor-support]` Add `coverage` option to runner
([#5836](https://github.com/facebook/jest/pull/5836))
* `[jest-haste-map]` Support extracting dynamic `import`s
([#5883](https://github.com/facebook/jest/pull/5883))
* `[expect]` Improve output format for mismatchedArgs in mock/spy calls.
Expand Down
1 change: 1 addition & 0 deletions packages/jest-editor-support/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface SpawnOptions {
}

export interface Options {
coverage?: boolean;
createProcess?(
workspace: ProjectWorkspace,
args: string[],
Expand Down
6 changes: 6 additions & 0 deletions packages/jest-editor-support/src/Runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ export default class Runner extends EventEmitter {
if (this.options.testFileNamePattern) {
args.push(this.options.testFileNamePattern);
}
if (this.options.coverage === true) {
args.push('--coverage');
}
if (this.options.coverage === false) {
args.push('--no-coverage');
}

const options = {
shell: this.options.shell,
Expand Down
39 changes: 39 additions & 0 deletions packages/jest-editor-support/src/__tests__/runner.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,45 @@ describe('Runner', () => {
expect((createProcess: any).mock.calls[0][1]).toContain('--watch');
});

it('calls createProcess with the --coverage arg when provided', () => {
const expected = '--coverage';

const workspace: any = {};
const options = {coverage: true};
const sut = new Runner(workspace, options);
sut.start(false);

const args = (createProcess: any).mock.calls[0][1];
const index = args.indexOf(expected);
expect(index).not.toBe(-1);
});

it('calls createProcess with the ---no-coverage arg when provided and false', () => {
const expected = '--no-coverage';

const workspace: any = {};
const options = {coverage: false};
const sut = new Runner(workspace, options);
sut.start(false);

const args = (createProcess: any).mock.calls[0][1];
const index = args.indexOf(expected);
expect(index).not.toBe(-1);
});

it('calls createProcess without the --coverage arg when undefined', () => {
const expected = '--coverage';

const workspace: any = {};
const options = {};
const sut = new Runner(workspace, options);
sut.start(false);

const args = (createProcess: any).mock.calls[0][1];
const index = args.indexOf(expected);
expect(index).toBe(-1);
});

it('calls createProcess with the --testNamePattern arg when provided', () => {
const expected = 'testNamePattern';

Expand Down
1 change: 1 addition & 0 deletions packages/jest-editor-support/src/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import type {ChildProcess} from 'child_process';
import type ProjectWorkspace from './project_workspace';

export type Options = {
coverage?: boolean,
createProcess?: (
workspace: ProjectWorkspace,
args: Array<string>,
Expand Down

0 comments on commit bce54cd

Please sign in to comment.