chore: drop node 10 and node 15 (#12220)

jestjs · Feb 9, 2022 · 7e484b2 · 7e484b2
1 parent 3ccde93
commit 7e484b2
Show file tree

Hide file tree

Showing 73 changed files with 216 additions and 360 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -68,5 +68,5 @@ workflows:
           partial: true
           matrix:
             parameters:
-              node-version: ['10', '12', '15', '16', '17']
+              node-version: ['12', '16', '17']
       - test-jest-jasmine
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -73,7 +73,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [10.x, 12.x, 14.x, 15.x, 16.x, 17.x]
+        node-version: [12.x, 14.x, 16.x, 17.x]
         os: [ubuntu-latest, macOS-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     needs: prepare-yarn-cache

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@
 
 ### Chore & Maintenance
 
+- `[*]` [**BREAKING**] Drop support for Node v10 and v15 and target first LTS `16.13.0` ([#12220](https://github.com/facebook/jest/pull/12220))
+
 ### Performance
 
 ## 27.5.1

diff --git a/e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap b/e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap
@@ -41,7 +41,7 @@ exports[`moduleNameMapper wrong array configuration 1`] = `
       12 | module.exports = () => 'test';
       13 |
 
-      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:579:17)
+      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:568:17)
       at Object.require (index.js:10:1)"
 `;
 
@@ -70,6 +70,6 @@ exports[`moduleNameMapper wrong configuration 1`] = `
       12 | module.exports = () => 'test';
       13 |
 
-      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:579:17)
+      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/resolver.js:568:17)
       at Object.require (index.js:10:1)"
 `;
diff --git a/e2e/__tests__/__snapshots__/resolveNoFileExtensions.test.ts.snap b/e2e/__tests__/__snapshots__/resolveNoFileExtensions.test.ts.snap
@@ -37,6 +37,6 @@ exports[`show error message with matching files 1`] = `
         |                  ^
       9 |
 
-      at Resolver.resolveModule (../../packages/jest-resolve/build/resolver.js:324:11)
+      at Resolver.resolveModule (../../packages/jest-resolve/build/resolver.js:317:11)
       at Object.require (index.js:8:18)"
 `;
diff --git a/e2e/__tests__/consoleLogOutputWhenRunInBand.test.ts b/e2e/__tests__/consoleLogOutputWhenRunInBand.test.ts
@@ -14,8 +14,6 @@ const DIR = path.resolve(__dirname, '../console-log-output-when-run-in-band');
 beforeEach(() => cleanup(DIR));
 afterAll(() => cleanup(DIR));
 
-const nodeMajorVersion = Number(process.versions.node.split('.')[0]);
-
 test('prints console.logs when run with forceExit', () => {
   writeFiles(DIR, {
     '__tests__/a-banana.js': `
@@ -24,26 +22,14 @@ test('prints console.logs when run with forceExit', () => {
     'package.json': '{}',
   });
 
-  const {stderr, exitCode, ...res} = runJest(DIR, [
+  const {stderr, stdout, exitCode} = runJest(DIR, [
     '-i',
     '--ci=false',
     '--forceExit',
   ]);
-  let {stdout} = res;
 
   const {rest, summary} = extractSummary(stderr);
 
-  if (nodeMajorVersion < 12) {
-    expect(stdout).toContain(
-      'at Object.<anonymous>.test (__tests__/a-banana.js:1:1)',
-    );
-
-    stdout = stdout.replace(
-      'at Object.<anonymous>.test (__tests__/a-banana.js:1:1)',
-      'at Object.<anonymous> (__tests__/a-banana.js:1:1)',
-    );
-  }
-
   expect(exitCode).toBe(0);
   expect(rest).toMatchSnapshot();
   expect(summary).toMatchSnapshot();

diff --git a/e2e/__tests__/detectOpenHandles.ts b/e2e/__tests__/detectOpenHandles.ts
@@ -5,7 +5,6 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {onNodeVersions} from '@jest/test-utils';
 import runJest, {runContinuous} from '../runJest';
 
 try {
@@ -81,16 +80,14 @@ it('does not report crypto random data', () => {
   expect(textAfterTest).toBe('');
 });
 
-onNodeVersions('>=12', () => {
-  it('does not report ELD histograms', () => {
-    const {stderr} = runJest('detect-open-handles', [
-      'histogram',
-      '--detectOpenHandles',
-    ]);
-    const textAfterTest = getTextAfterTest(stderr);
+it('does not report ELD histograms', () => {
+  const {stderr} = runJest('detect-open-handles', [
+    'histogram',
+    '--detectOpenHandles',
+  ]);
+  const textAfterTest = getTextAfterTest(stderr);
 
-    expect(textAfterTest).toBe('');
-  });
+  expect(textAfterTest).toBe('');
 });
 
 describe('notify', () => {
@@ -109,17 +106,15 @@ describe('notify', () => {
   });
 });
 
-onNodeVersions('>=12', () => {
-  it('does not report timeouts using unref', () => {
-    // The test here is basically that it exits cleanly without reporting anything (does not need `until`)
-    const {stderr} = runJest('detect-open-handles', [
-      'unref',
-      '--detectOpenHandles',
-    ]);
-    const textAfterTest = getTextAfterTest(stderr);
+it('does not report timeouts using unref', () => {
+  // The test here is basically that it exits cleanly without reporting anything (does not need `until`)
+  const {stderr} = runJest('detect-open-handles', [
+    'unref',
+    '--detectOpenHandles',
+  ]);
+  const textAfterTest = getTextAfterTest(stderr);
 
-    expect(textAfterTest).toBe('');
-  });
+  expect(textAfterTest).toBe('');
 });
 
 it('prints out info about open handlers from inside tests', async () => {

diff --git a/e2e/__tests__/errorOnDeprecated.test.ts b/e2e/__tests__/errorOnDeprecated.test.ts
@@ -31,30 +31,14 @@ const SHOULD_NOT_PASS_IN_JEST = new Set([
   'spyOnProperty.test.js',
 ]);
 
-const nodeMajorVersion = Number(process.versions.node.split('.')[0]);
-
 testFiles.forEach(testFile => {
   test(`${testFile} errors in errorOnDeprecated mode`, () => {
     const result = runJest('error-on-deprecated', [
       testFile,
       '--errorOnDeprecated',
     ]);
     expect(result.exitCode).toBe(1);
-    let {rest} = extractSummary(result.stderr);
-
-    if (
-      nodeMajorVersion < 12 &&
-      testFile === 'defaultTimeoutInterval.test.js'
-    ) {
-      const lineEntry = '(__tests__/defaultTimeoutInterval.test.js:10:3)';
-
-      expect(rest).toContain(`at Object.<anonymous>.test ${lineEntry}`);
-
-      rest = rest.replace(
-        `at Object.<anonymous>.test ${lineEntry}`,
-        `at Object.<anonymous> ${lineEntry}`,
-      );
-    }
+    const {rest} = extractSummary(result.stderr);
 
     expect(rest).toMatchSnapshot();
   });

diff --git a/e2e/__tests__/failures.test.ts b/e2e/__tests__/failures.test.ts
@@ -20,8 +20,6 @@ function cleanStderr(stderr: string) {
     .replace(new RegExp('Failed: Object {', 'g'), 'thrown: Object {');
 }
 
-const nodeMajorVersion = Number(process.versions.node.split('.')[0]);
-
 beforeAll(() => {
   runYarnInstall(dir);
 });
@@ -37,18 +35,6 @@ test('not throwing Error objects', () => {
   stderr = runJest(dir, ['assertionCount.test.js']).stderr;
   expect(cleanStderr(stderr)).toMatchSnapshot();
   stderr = runJest(dir, ['duringTests.test.js']).stderr;
-
-  if (nodeMajorVersion < 12) {
-    const lineEntry = '(__tests__/duringTests.test.js:43:8)';
-
-    expect(stderr).toContain(`at Object.<anonymous>.done ${lineEntry}`);
-
-    stderr = stderr.replace(
-      `at Object.<anonymous>.done ${lineEntry}`,
-      `at Object.<anonymous> ${lineEntry}`,
-    );
-  }
-
   expect(cleanStderr(stderr)).toMatchSnapshot();
   stderr = runJest(dir, ['throwObjectWithStackProp.test.js']).stderr;
   expect(cleanStderr(stderr)).toMatchSnapshot();

diff --git a/e2e/__tests__/requireMainAfterCreateRequire.test.ts b/e2e/__tests__/requireMainAfterCreateRequire.test.ts
@@ -4,19 +4,17 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
+
 import * as path from 'path';
-import {onNodeVersions} from '@jest/test-utils';
 import runJest from '../runJest';
 
-onNodeVersions('>=12.2.0', () => {
-  test('`require.main` not undefined after createRequire', () => {
-    const {stdout} = runJest('require-main-after-create-require');
+test('`require.main` not undefined after createRequire', () => {
+  const {stdout} = runJest('require-main-after-create-require');
 
-    expect(stdout).toBe(
-      path.join(
-        __dirname,
-        '../require-main-after-create-require/__tests__/parent.test.js',
-      ),
-    );
-  });
+  expect(stdout).toBe(
+    path.join(
+      __dirname,
+      '../require-main-after-create-require/__tests__/parent.test.js',
+    ),
+  );
 });
diff --git a/e2e/__tests__/unexpectedToken.test.ts b/e2e/__tests__/unexpectedToken.test.ts
@@ -11,7 +11,6 @@ import {cleanup, writeFiles} from '../Utils';
 import runJest from '../runJest';
 
 const DIR = path.resolve(tmpdir(), 'unexpected-token');
-const nodeMajorVersion = Number(process.versions.node.split('.')[0]);
 
 beforeEach(() => cleanup(DIR));
 afterEach(() => cleanup(DIR));
@@ -53,13 +52,9 @@ test('triggers unexpected token error message for untranspiled node_modules', ()
   expect(stdout).toBe('');
   expect(stderr).toMatch(/Jest encountered an unexpected token/);
   expect(stderr).toMatch(/import {module}/);
-  if (nodeMajorVersion < 12) {
-    expect(stderr).toMatch(/Unexpected token/);
-  } else {
-    expect(stderr).toMatch(
-      /SyntaxError: Cannot use import statement outside a module/,
-    );
-  }
+  expect(stderr).toMatch(
+    /SyntaxError: Cannot use import statement outside a module/,
+  );
 });
 
 test('does not trigger unexpected token error message for regular syntax errors', () => {

diff --git a/jest.config.js b/jest.config.js
@@ -34,10 +34,7 @@ module.exports = {
   snapshotFormat: {
     escapeString: false,
   },
-  snapshotSerializers: [
-    // change to require.resolve('pretty-format/ConvertAnsi') when we drop Node 10
-    '<rootDir>/packages/pretty-format/build/plugins/ConvertAnsi.js',
-  ],
+  snapshotSerializers: [require.resolve('pretty-format/ConvertAnsi')],
   testPathIgnorePatterns: [
     '/__arbitraries__/',
     '/__typetests__/',

diff --git a/package.json b/package.json
@@ -12,14 +12,14 @@
     "@crowdin/cli": "^3.5.2",
     "@jest/globals": "workspace:*",
     "@jest/test-utils": "workspace:*",
-    "@tsconfig/node10": "^1.0.8",
+    "@tsconfig/node12": "^1.0.9",
     "@tsd/typescript": "~4.1.5",
     "@types/babel__core": "^7.0.0",
     "@types/babel__generator": "^7.0.0",
     "@types/babel__template": "^7.0.0",
     "@types/dedent": "0.7.0",
     "@types/jest": "^26.0.15",
-    "@types/node": "~10.14.0",
+    "@types/node": "~12.12.0",
     "@types/which": "^2.0.0",
     "@typescript-eslint/eslint-plugin": "^4.1.0",
     "@typescript-eslint/parser": "^4.1.0",
@@ -145,7 +145,7 @@
     "logo": "https://opencollective.com/jest/logo.txt"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "resolutions": {
     "@jest/create-cache-key-function": "workspace:*",

diff --git a/packages/babel-jest/package.json b/packages/babel-jest/package.json
@@ -36,7 +36,7 @@
     "@babel/core": "^7.8.0"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/babel-plugin-jest-hoist/package.json b/packages/babel-plugin-jest-hoist/package.json
@@ -7,7 +7,7 @@
     "directory": "packages/babel-plugin-jest-hoist"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "license": "MIT",
   "main": "./build/index.js",

diff --git a/packages/babel-preset-jest/package.json b/packages/babel-preset-jest/package.json
@@ -20,7 +20,7 @@
     "@babel/core": "^7.0.0"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/diff-sequences/package.json b/packages/diff-sequences/package.json
@@ -16,7 +16,7 @@
     "diff"
   ],
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "main": "./build/index.js",
   "types": "./build/index.d.ts",

diff --git a/packages/expect/package.json b/packages/expect/package.json
@@ -33,7 +33,7 @@
     "tsd-lite": "^0.5.1"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-changed-files/package.json b/packages/jest-changed-files/package.json
@@ -22,7 +22,7 @@
     "throat": "^6.0.1"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-circus/package.json b/packages/jest-circus/package.json
@@ -49,7 +49,7 @@
     "graceful-fs": "^4.2.9"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-cli/package.json b/packages/jest-cli/package.json
@@ -44,7 +44,7 @@
     "jest": "./bin/jest.js"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "repository": {
     "type": "git",

diff --git a/packages/jest-config/package.json b/packages/jest-config/package.json
@@ -59,7 +59,7 @@
     "typescript": "^4.0.3"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-console/package.json b/packages/jest-console/package.json
@@ -29,7 +29,7 @@
     "@types/node": "*"
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/jest-core/package.json b/packages/jest-core/package.json
@@ -58,7 +58,7 @@
     }
   },
   "engines": {
-    "node": "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.13.0 || ^14.15.0 || ^16.13.0 || >=17.0.0"
   },
   "repository": {
     "type": "git",