Skip to content

Commit

Permalink
standardize filenames in e2e (#7471)
Browse files Browse the repository at this point in the history 
* standardizing file names to fit facebook standards

* updating filenames to better fit facebook standards

* standardizing jest-runner filenames to fit facebook standards

* standardizing file names in /e2e/before-all-filtered

* resolving naming discrepencies inside of files

* standardizing filenames in e2e/before-each-queue and corresponding tests

* standardizing several tests in ./e2e/__test__/

* standardizing filenames for babel-plugin-jest-hoist and related test files

* standardizing file-names for folders 'browser-support' and 'clear-cache' and their corresponding test files

* resolving issue with karma referencing non-standard browserTest

* resolving issue with karma referencing non-standard browserTest filename

* standardizing file names to fit facebook standards

* updating filenames to better fit facebook standards

* Add issue template labels (#7470)

* Add issue template labels

* Lint

* standardizing jest-runner filenames to fit facebook standards

* allow `bail` setting to control when to bail out of a failing test run (#7335)

* standardizing file names in /e2e/before-all-filtered

* resolving naming discrepencies inside of files

* standardizing filenames in e2e/before-each-queue and corresponding tests

* standardizing several tests in ./e2e/__test__/

* standardizing filenames for babel-plugin-jest-hoist and related test files

* standardizing file-names for folders 'browser-support' and 'clear-cache' and their corresponding test files

* resolving issue with karma referencing non-standard browserTest

* resolving issue with karma referencing non-standard browserTest filename

* standardizing file names in e2e/__test__

* standardizing file names in compare-dom-nodes

* standardizing file names for coverage-report and coverage-remap

* updating case sensitive filenames

* renaming files to fit facebook standards

* adding case sensitive file changes

* resolving dependency issues after renaming case sensitive files.

* standardizing file names to fit facebook standards

* adjusting file names and snapshots to fit facebook standards

* adjusting file names to fit facebook standards

* resolves bug with nodeAssertionError not being found by test suite

* changing references to match file name

* changing file name to check test-jest-circus

* readding a previously deleted snapshot

* Update e2e/bad-source-map/__tests__/badSourceMap.js comment to reflect new file name

Co-Authored-By: GGonryun <[email protected]>

* improving file naming conventions letters g & j

* changing filename to fit facebook standards

* renaming filenames to fit facebook standards for 'L'

* renaming filenames to fit facebook standards for 'M'

* renaming filenames to fit facebook standards for 'N'

* resolving leftover merge conflicts

* reverting error in naming by changing filename back to uppercase

* renaming filenames 'O' to fit facebook standards.

* renaming filenames 'P' to fit facebook standards.

* renaming filenames 'R' to fit facebook standards.

* renaming filenames 'S' to fit facebook standards.

* changing regex to match temporary folder name

* renaming filenames 'T' to fit facebook standards.

* renaming filenames 'U' to fit facebook standards.

* renaming filenames 'V' to fit facebook standards.

* renaming filenames 'W' to fit facebook standards.

* updating snapshots to reflect standardized file names

* Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pattern-temp/package.json

* Rename e2e/test-name-pattern/package.json to e2e/test-name-pattern-skipped/package.json

* Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pattern.package.json

* Rename e2e/test-name-pattern-temp/package.json to e2e/test-name-pattern/package.json

* Rename e2e/test-name-pattern.package.json to e2e/test-name-pattern-skipped/package.json

* removing left over files and adjusting file names previously missed

* deleting more leftover files
  • Loading branch information
@GGonryun @thymikee
GGonryun authored and thymikee committed Jan 10, 2019
1 parent e1c226c commit 5f4e5cd
Show file tree
Hide file tree
Showing 307 changed files with 401 additions and 400 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
- `[jest-haste-map]` Refactor `dependencyExtractor` and tests ([#7385](https://github.com/facebook/jest/pull/7385))
- `[docs]` Clearify conditional setting of `NODE_ENV` ([#7369](https://github.com/facebook/jest/pull/7369))
- `[docs]` Clarify conditional setting of `NODE_ENV` ([#7369](https://github.com/facebook/jest/pull/7369))
- `[*]` Standardize file names ([#7316](https://github.com/facebook/jest/pull/7316), [#7266](https://github.com/facebook/jest/pull/7266), [#7238](https://github.com/facebook/jest/pull/7238), [#7314](https://github.com/facebook/jest/pull/7314), [#7467](https://github.com/facebook/jest/pull/7467), [#7464](https://github.com/facebook/jest/pull/7464))
- `[*]` Standardize file names ([#7316](https://github.com/facebook/jest/pull/7316), [#7266](https://github.com/facebook/jest/pull/7266), [#7238](https://github.com/facebook/jest/pull/7238), [#7314](https://github.com/facebook/jest/pull/7314), [#7467](https://github.com/facebook/jest/pull/7467), [#7464](https://github.com/facebook/jest/pull/7464)), [#7471](https://github.com/facebook/jest/pull/7471))
- `[docs]` Add `testPathIgnorePatterns` in CLI documentation ([#7440](https://github.com/facebook/jest/pull/7440))
- `[docs]` Removed misleading text about `describe()` grouping together tests into a test suite ([#7434](https://github.com/facebook/jest/pull/7434))

Expand Down
19 changes: 0 additions & 19 deletions e2e/__tests__/__snapshots__/before-all-filtered.js.snap
View file

This file was deleted.

19 changes: 0 additions & 19 deletions e2e/__tests__/__snapshots__/before-each-queue.js.snap
View file

This file was deleted.

19 changes: 19 additions & 0 deletions e2e/__tests__/__snapshots__/beforeAllFiltered.js.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Correct BeforeAll run ensures the BeforeAll of ignored suite is not run 1`] = `
" console.log __tests__/beforeAllFiltered.test.js:5
beforeAll 1
console.log __tests__/beforeAllFiltered.test.js:8
beforeEach 1
console.log __tests__/beforeAllFiltered.test.js:17
It Foo
console.log __tests__/beforeAllFiltered.test.js:11
afterEach 1
console.log __tests__/beforeAllFiltered.test.js:14
afterAll 1
"
`;
19 changes: 19 additions & 0 deletions e2e/__tests__/__snapshots__/beforeEachQueue.js.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Correct beforeEach order ensures the correct order for beforeEach 1`] = `
" console.log __tests__/beforeEachQueue.test.js:5
BeforeEach
console.log __tests__/beforeEachQueue.test.js:9
It Foo
console.log __tests__/beforeEachQueue.test.js:12
BeforeEach Inline Foo
console.log __tests__/beforeEachQueue.test.js:5
BeforeEach
console.log __tests__/beforeEachQueue.test.js:17
It Bar
"
`;
0 .../cli-handles-exact-filenames.test.js.snap → ...s__/cliHandlesExactFilenames.test.js.snap
View file
File renamed without changes.
0 ..._log_output_when_run_in_band.test.js.snap → ...onsoleLogOutputWhenRunInBand.test.js.snap
View file
File renamed without changes.
0 ...apshots__/coverage_remapping.test.js.snap → ...napshots__/coverageRemapping.test.js.snap
View file
File renamed without changes.
48 changes: 24 additions & 24 deletions ..._snapshots__/coverage_report.test.js.snap → ...__snapshots__/coverageReport.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---------------|----------|----------|----------|----------|-------------------|
All files | 100 | 100 | 100 | 100 | |
a | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
b | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
---------------|----------|----------|----------|----------|-------------------|"
`;

Expand All @@ -17,7 +17,7 @@ exports[`collects coverage only from multiple specified files 1`] = `
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
--------------|----------|----------|----------|----------|-------------------|
All files | 100 | 100 | 100 | 100 | |
OtherFile.js | 100 | 100 | 100 | 100 | |
otherFile.js | 100 | 100 | 100 | 100 | |
setup.js | 100 | 100 | 100 | 100 | |
--------------|----------|----------|----------|----------|-------------------|"
`;
Expand All @@ -36,7 +36,7 @@ exports[`collects coverage only from specified files avoiding dependencies 1`] =
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files | 85.71 | 100 | 50 | 100 | |
Sum.js | 85.71 | 100 | 50 | 100 | |
sum.js | 85.71 | 100 | 50 | 100 | |
----------|----------|----------|----------|----------|-------------------|"
`;

Expand All @@ -48,14 +48,14 @@ File | % Stmts | % Branch | % Funcs | % Lines
-------------------------------------|----------|----------|----------|----------|-------------------|
All files | 56.52 | 0 | 50 | 55.56 | |
coverage-report | 41.18 | 0 | 25 | 42.86 | |
OtherFile.js | 100 | 100 | 100 | 100 | |
Sum.js | 85.71 | 100 | 50 | 100 | |
SumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
notRequiredInTestSuite.js | 0 | 0 | 0 | 0 | 8,15,16,17,19 |
otherFile.js | 100 | 100 | 100 | 100 | |
sum.js | 85.71 | 100 | 50 | 100 | |
sumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
coverage-report/cached-duplicates/a | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
coverage-report/cached-duplicates/b | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
-------------------------------------|----------|----------|----------|----------|-------------------|"
`;

Expand All @@ -74,14 +74,14 @@ File | % Stmts | % Branch | % Funcs | % Lines
-------------------------------------|----------|----------|----------|----------|-------------------|
All files | 56.52 | 0 | 50 | 55.56 | |
coverage-report | 41.18 | 0 | 25 | 42.86 | |
OtherFile.js | 100 | 100 | 100 | 100 | |
Sum.js | 85.71 | 100 | 50 | 100 | |
SumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
notRequiredInTestSuite.js | 0 | 0 | 0 | 0 | 8,15,16,17,19 |
otherFile.js | 100 | 100 | 100 | 100 | |
sum.js | 85.71 | 100 | 50 | 100 | |
sumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
coverage-report/cached-duplicates/a | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
coverage-report/cached-duplicates/b | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
-------------------------------------|----------|----------|----------|----------|-------------------|"
`;
Expand All @@ -98,14 +98,14 @@ File | % Stmts | % Branch | % Funcs | % Lines
-------------------------------------|----------|----------|----------|----------|-------------------|
All files | 56.52 | 0 | 50 | 55.56 | |
coverage-report | 41.18 | 0 | 25 | 42.86 | |
OtherFile.js | 100 | 100 | 100 | 100 | |
Sum.js | 85.71 | 100 | 50 | 100 | |
SumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
notRequiredInTestSuite.js | 0 | 0 | 0 | 0 | 8,15,16,17,19 |
otherFile.js | 100 | 100 | 100 | 100 | |
sum.js | 85.71 | 100 | 50 | 100 | |
sumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
coverage-report/cached-duplicates/a | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
coverage-report/cached-duplicates/b | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
-------------------------------------|----------|----------|----------|----------|-------------------|"
`;
Expand All @@ -115,14 +115,14 @@ File | % Stmts | % Branch | % Funcs | % Lines
-------------------------------------|----------|----------|----------|----------|-------------------|
All files | 56.52 | 0 | 50 | 55.56 | |
coverage-report | 41.18 | 0 | 25 | 42.86 | |
OtherFile.js | 100 | 100 | 100 | 100 | |
Sum.js | 85.71 | 100 | 50 | 100 | |
SumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
notRequiredInTestSuite.js | 0 | 0 | 0 | 0 | 8,15,16,17,19 |
otherFile.js | 100 | 100 | 100 | 100 | |
sum.js | 85.71 | 100 | 50 | 100 | |
sumDependency.js | 0 | 0 | 0 | 0 | 8,10,12 |
coverage-report/cached-duplicates/a | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
coverage-report/cached-duplicates/b | 100 | 100 | 100 | 100 | |
Identical.js | 100 | 100 | 100 | 100 | |
identical.js | 100 | 100 | 100 | 100 | |
-------------------------------------|----------|----------|----------|----------|-------------------|"
`;
Expand Down
0 ...apshots__/coverage_threshold.test.js.snap → ...napshots__/coverageThreshold.test.js.snap
View file
File renamed without changes.
0 ...erage_transform_instrumented.test.js.snap → ...overageTransformInstrumented.test.js.snap
View file
File renamed without changes.
14 changes: 7 additions & 7 deletions ..._/custom_matcher_stack_trace.test.js.snap → ...ts__/customMatcherStackTrace.test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`works with custom matchers 1`] = `
"FAIL __tests__/custom_matcher.test.js
"FAIL __tests__/customMatcher.test.js
Custom matcher
✓ passes
✓ fails
Expand All @@ -19,12 +19,12 @@ exports[`works with custom matchers 1`] = `
47 |
48 | // This expecation fails due to an error we throw (intentionally)
at Error (__tests__/custom_matcher.test.js:45:13)
at baz (__tests__/custom_matcher.test.js:43:23)
at bar (__tests__/custom_matcher.test.js:42:23)
at foo (__tests__/custom_matcher.test.js:52:7)
at Object.callback (__tests__/custom_matcher.test.js:11:18)
at Object.toCustomMatch (__tests__/custom_matcher.test.js:53:8)
at Error (__tests__/customMatcher.test.js:45:13)
at baz (__tests__/customMatcher.test.js:43:23)
at bar (__tests__/customMatcher.test.js:42:23)
at foo (__tests__/customMatcher.test.js:52:7)
at Object.callback (__tests__/customMatcher.test.js:11:18)
at Object.toCustomMatch (__tests__/customMatcher.test.js:53:8)
"
`;
0 ...snapshots__/custom_reporters.test.js.snap → ..._snapshots__/customReporters.test.js.snap
View file
File renamed without changes.
0 ...__snapshots__/detect_open_handles.js.snap → ..._/__snapshots__/detectOpenHandles.js.snap
View file
File renamed without changes.
12 changes: 6 additions & 6 deletions e2e/__tests__/__snapshots__/each.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ exports[`formats args with pretty format when given %p 1`] = `
`;

exports[`runs only the describe.only.each tests 1`] = `
"PASS __tests__/describe-only.test.js
"PASS __tests__/describeOnly.test.js
passes all rows expected true == true
✓ passes
✓ passes
Expand All @@ -46,7 +46,7 @@ exports[`runs only the describe.only.each tests 1`] = `
`;

exports[`shows error message when not enough arguments are supplied to tests 1`] = `
"FAIL __tests__/each-exception.test.js
"FAIL __tests__/eachException.test.js
✕ throws exception when one argument too few are supplied $left == $right
✕ throws exception when not enough arguments are supplied $left == $right
Expand All @@ -72,7 +72,7 @@ exports[`shows error message when not enough arguments are supplied to tests 1`]
10 | \${true} | \${true}
11 | \${true}
at Object.<anonymous> (__tests__/each-exception.test.js:8:1)
at Object.<anonymous> (__tests__/eachException.test.js:8:1)
● throws exception when not enough arguments are supplied $left == $right
Expand All @@ -95,13 +95,13 @@ exports[`shows error message when not enough arguments are supplied to tests 1`]
21 | \${true} | \${true}
22 | \`(
at Object.<anonymous> (__tests__/each-exception.test.js:19:1)
at Object.<anonymous> (__tests__/eachException.test.js:19:1)
"
`;
exports[`shows only the tests with .only as being ran 1`] = `
"PASS __tests__/each-only.test.js
"PASS __tests__/eachOnly.test.js
✓ passes one row expected true == true
✓ passes one row expected true == true
✓ passes one row expected true == true
Expand All @@ -112,7 +112,7 @@ exports[`shows only the tests with .only as being ran 1`] = `
`;
exports[`shows only the tests without .skip as being ran 1`] = `
"PASS __tests__/each-skip.test.js
"PASS __tests__/eachSkip.test.js
✓ passes one row expected true == true
✓ passes one row expected true == true
✓ passes one row expected true == true
Expand Down
Loading

0 comments on commit 5f4e5cd

Please sign in to comment.