fix: pass root in babel config (#12689)

Co-authored-by: Bradford Lemley <[email protected]>

.yarnrc.yml

@@ -18,8 +18,6 @@ packageExtensions:
     peerDependencies:
       "@babel/preset-env": ^7.1.6
   react-native@*:
-    dependencies:
-      metro-babel-register: 0.67.0
     peerDependencies:
       "@babel/preset-env": ^7.1.6
 

CHANGELOG.md

@@ -59,6 +59,7 @@
 
 ### Fixes
 
+- `[babel-jest]` [**BREAKING**] Pass `rootDir` as `root` in Babel's options ([#12689](https://github.com/facebook/jest/pull/12689))
 - `[expect]` Move typings of `.not`, `.rejects` and `.resolves` modifiers outside of `Matchers` interface ([#12346](https://github.com/facebook/jest/pull/12346))
 - `[expect]` Throw useful error if `expect.extend` is called with invalid matchers ([#12488](https://github.com/facebook/jest/pull/12488))
 - `[expect]` Fix `iterableEquality` ignores other properties ([#8359](https://github.com/facebook/jest/pull/8359))

e2e/__tests__/multiProjectRunner.test.ts

@@ -572,3 +572,41 @@ describe("doesn't bleed module file extensions resolution with multiple workers"
     expect(stderr).toMatch('PASS project2/__tests__/project2.test.js');
   });
 });
+
+describe('Babel config in individual project works in multi-project', () => {
+  it('Prj-1 works individually', () => {
+    const result = runJest('multi-project-babel/prj-1');
+    expect(result.stderr).toMatch('PASS ./index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+  it('Prj-2 works individually', () => {
+    const result = runJest('multi-project-babel/prj-2');
+    expect(result.stderr).toMatch('PASS ./index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+  it('Prj-3 works individually', () => {
+    const result = runJest('multi-project-babel/prj-3');
+    expect(result.stderr).toMatch('PASS src/index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+  it('Prj-4 works individually', () => {
+    const result = runJest('multi-project-babel/prj-4');
+    expect(result.stderr).toMatch('PASS src/index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+  it('Prj-5 works individually', () => {
+    const result = runJest('multi-project-babel/prj-5');
+    expect(result.stderr).toMatch('PASS src/index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+  it('All project work when running from multiproject', () => {
+    const result = runJest('multi-project-babel');
+    expect(result.stderr).toMatch('PASS prj-1/index.test.js');
+    expect(result.stderr).toMatch('PASS prj-2/index.test.js');
+    expect(result.stderr).toMatch('PASS prj-3/src/index.test.js');
+    expect(result.stderr).toMatch('PASS prj-4/src/index.test.js');
+    expect(result.stderr).toMatch('PASS prj-5/src/index.test.js');
+    expect(result.stderr).toMatch('PASS prj-3/src/index.test.js');
+    expect(result.exitCode).toBe(0);
+  });
+});

e2e/global-setup/projects.jest.config.js

@@ -15,13 +15,19 @@ module.exports = {
       globalSetup: '<rootDir>/setup.js',
       rootDir: path.resolve(__dirname, './project-1'),
       testMatch: ['<rootDir>/**/*.test.js'],
+      transform: {
+        '\\.[jt]sx?$': [require.resolve('babel-jest'), {root: __dirname}],
+      },
       transformIgnorePatterns: ['/node_modules/', '/packages/'],
     },
     {
       displayName: 'project-2',
       globalSetup: '<rootDir>/setup.js',
       rootDir: path.resolve(__dirname, './project-2'),
       testMatch: ['<rootDir>/**/*.test.js'],
+      transform: {
+        '\\.[jt]sx?$': [require.resolve('babel-jest'), {root: __dirname}],
+      },
       transformIgnorePatterns: ['/node_modules/', '/packages/'],
     },
   ],

e2e/multi-project-babel/package.json

@@ -0,0 +1,15 @@
+{
+  "jest": {
+    "projects": [
+      {
+        "rootDir": "<rootDir>/prj-1"
+      },
+      {
+        "rootDir": "<rootDir>/prj-2"
+      },
+      "<rootDir>/prj-3",
+      "<rootDir>/prj-4",
+      "<rootDir>/prj-5"
+    ]
+  }
+}

e2e/multi-project-babel/prj-1/babel.config.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = {
+  presets: ['@babel/preset-flow'],
+};

e2e/multi-project-babel/prj-1/index.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = (text: string) => text;

e2e/multi-project-babel/prj-1/index.test.js

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const f = require('./');
+
+it('Transpiles', () => {
+  expect(f('test')).toBe('test');
+});

e2e/multi-project-babel/prj-1/package.json

@@ -0,0 +1 @@
+{}

e2e/multi-project-babel/prj-2/.babelrc.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = {
+  presets: ['@babel/preset-flow'],
+};

e2e/multi-project-babel/prj-2/index.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = (text: string) => text;

e2e/multi-project-babel/prj-2/index.test.js

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const f = require('./');
+
+it('Transpiles', () => {
+  expect(f('test')).toBe('test');
+});

e2e/multi-project-babel/prj-2/package.json

@@ -0,0 +1 @@
+{}

e2e/multi-project-babel/prj-3/package.json

@@ -0,0 +1,5 @@
+{
+  "jest": {
+    "rootDir": "src"
+  }
+}

e2e/multi-project-babel/prj-3/src/babel.config.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = {
+  presets: ['@babel/preset-flow'],
+};

e2e/multi-project-babel/prj-3/src/index.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = (text: string) => text;

e2e/multi-project-babel/prj-3/src/index.test.js

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const f = require('./');
+
+it('Transpiles', () => {
+  expect(f('test')).toBe('test');
+});

e2e/multi-project-babel/prj-4/.babelrc.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = {
+  presets: ['@babel/preset-flow'],
+};

e2e/multi-project-babel/prj-4/package.json

@@ -0,0 +1,5 @@
+{
+  "jest": {
+    "rootDir": "src"
+  }
+}

e2e/multi-project-babel/prj-4/src/index.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = (text: string) => text;

e2e/multi-project-babel/prj-4/src/index.test.js

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const f = require('./');
+
+it('Transpiles', () => {
+  expect(f('test')).toBe('test');
+});

e2e/multi-project-babel/prj-5/.babelrc.js

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = {
+  presets: ['@babel/preset-flow'],
+};

e2e/multi-project-babel/prj-5/package.json

@@ -0,0 +1,5 @@
+{
+  "jest": {
+    "rootDir": "src"
+  }
+}

e2e/multi-project-babel/prj-5/src/index.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+module.exports = (text: string) => text;

e2e/multi-project-babel/prj-5/src/index.test.js

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const f = require('./');
+
+it('Transpiles', () => {
+  expect(f('test')).toBe('test');
+});

examples/react-native/jest.config.js

@@ -3,9 +3,6 @@ const {resolve} = require('path');
 module.exports = {
   preset: 'react-native',
   testEnvironment: 'jsdom',
-  transform: {
-    '\\.(js|ts|tsx)$': require.resolve('react-native/jest/preprocessor.js'),
-  },
   // this is specific to the Jest repo, not generally needed (the files we ignore will be in node_modules which is ignored by default)
   transformIgnorePatterns: [resolve(__dirname, '../../packages')],
 };

jest.config.mjs

@@ -48,6 +48,7 @@ export default {
     '/e2e/custom-*',
     '/e2e/test-in-root',
     '/e2e/run-programmatically-multiple-projects',
+    '/e2e/multi-project-babel',
     '\\.snap$',
     '/packages/.*/build',
     '/packages/.*/src/__tests__/setPrettyPrint.ts',

package.json

@@ -165,8 +165,7 @@
   "resolutions": {
     "babel-jest": "workspace:*",
     "jest": "workspace:*",
-    "jest-environment-node": "workspace:*",
-    "react-native": "patch:react-native@npm:0.68.1#.yarn/patches/react-native-npm-0.68.0-9eb3ecb60a.patch"
+    "jest-environment-node": "workspace:*"
   },
   "packageManager": "[email protected]"
 }

packages/babel-jest/src/index.ts

@@ -173,10 +173,11 @@ export const createTransformer: TransformerCreator<
     filename: string,
     transformOptions: JestTransformOptions,
   ): TransformOptions {
-    const {cwd} = transformOptions.config;
-    // `cwd` first to allow incoming options to override it
+    const {cwd, rootDir} = transformOptions.config;
+    // `cwd` and `root` first to allow incoming options to override it
     return {
       cwd,
+      root: rootDir,
       ...options,
       caller: {
         ...options.caller,

packages/jest-runtime/src/__mocks__/createRuntime.js

@@ -37,36 +37,30 @@ const setupModuleNameMapper = (config, rootDir) => {
   return [];
 };
 
-const setupTransform = (config, rootDir) => {
+const setupTransform = (config, rootDir, cwd) => {
   if (config?.transform) {
     const transform = config.transform;
     return Object.keys(transform).map(regex => [
       regex,
       path.resolve(rootDir, transform[regex]),
     ]);
   }
-  return [['^.+\\.[jt]sx?$', require.resolve('babel-jest')]];
+  return [['^.+\\.[jt]sx?$', require.resolve('babel-jest'), {root: cwd}]];
 };
 
 module.exports = async function createRuntime(filename, projectConfig) {
   const rootDir = path.resolve(path.dirname(filename), 'test_root');
+  const cwd = path.resolve(__dirname, '../../../..');
 
   const moduleNameMapper = setupModuleNameMapper(projectConfig, rootDir);
-  const transform = setupTransform(projectConfig, rootDir);
+  const transform = setupTransform(projectConfig, rootDir, cwd);
 
   projectConfig = makeProjectConfig({
     cacheDirectory: getCacheDirectory(),
-    cwd: path.resolve(__dirname, '..', '..', '..', '..'),
+    cwd,
     haste: {
-      hasteImplModulePath: path.resolve(
-        __dirname,
-        '..',
-        '..',
-        '..',
-        'jest-haste-map',
-        'src',
-        '__tests__',
-        'haste_impl.js',
+      hasteImplModulePath: require.resolve(
+        '../../../jest-haste-map/src/__tests__/haste_impl.js',
       ),
     },
     id: `Runtime-${filename.replace(/\W/, '-')}.tests`,