Skip to content

Commit

Permalink
fix: skip ELDHISTOGRAM for --detectOpenHandles (#10417)
Browse files Browse the repository at this point in the history
  • Loading branch information
0cl authored Aug 19, 2020
1 parent 2e30f52 commit 4a9ebb4
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- `[jest-core]` Don't report ELDHistogram as open handle ([#10417](https://github.com/facebook/jest/pull/10417))
- `[jest-matcher-utils]` Fix diffing object contain readonly symbol key object ([#10414](https://github.com/facebook/jest/pull/10414))
- `[jest-reporters]` Fixes notify reporter on Linux (using notify-send) ([#10393](https://github.com/facebook/jest/pull/10400))
- `[jest-snapshot]` Correctly handles arrays and property matchers in snapshots ([#10404](https://github.com/facebook/jest/pull/10404))
Expand Down
12 changes: 12 additions & 0 deletions e2e/__tests__/detectOpenHandles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,18 @@ it('does not report promises', () => {
expect(textAfterTest).toBe('');
});

onNodeVersions('>=11.10.0', () => {
it('does not report ELD histograms', () => {
const {stderr} = runJest('detect-open-handles', [
'histogram',
'--detectOpenHandles',
]);
const textAfterTest = getTextAfterTest(stderr);

expect(textAfterTest).toBe('');
});
});

describe('notify', () => {
it('does not report --notify flag', () => {
if (process.platform === 'win32') {
Expand Down
13 changes: 13 additions & 0 deletions e2e/detect-open-handles/__tests__/histogram.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
const {monitorEventLoopDelay} = require('perf_hooks');

test('something', () => {
const histogram = monitorEventLoopDelay();
histogram.enable();
expect(true).toBe(true);
});
6 changes: 5 additions & 1 deletion packages/jest-core/src/collectHandles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ export default function collectHandles(): () => Array<Error> {
_triggerAsyncId,
resource: {} | NodeJS.Timeout,
) {
if (type === 'PROMISE' || type === 'TIMERWRAP') {
if (
type === 'PROMISE' ||
type === 'TIMERWRAP' ||
type === 'ELDHISTOGRAM'
) {
return;
}
const error = new ErrorWithStack(type, initHook);
Expand Down

0 comments on commit 4a9ebb4

Please sign in to comment.