fix: correctly throw an error if jest-environment-jsdom is missing

jestjs · Apr 26, 2022 · 362c6f8 · 362c6f8
1 parent d9f6aaf
commit 362c6f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### Fixes
 
 - `[jest-circus]` Improve `test.concurrent` ([#12748](https://github.com/facebook/jest/pull/12748))
+- `[jest-resolve]` Correctly throw an error if jsdom env is used, but not installed ([#12749](https://github.com/facebook/jest/pull/12749))
 
 ### Chore & Maintenance
 

diff --git a/packages/jest-resolve/src/utils.ts b/packages/jest-resolve/src/utils.ts
@@ -98,6 +98,11 @@ export const resolveTestEnvironment = ({
   testEnvironment: string;
   requireResolveFunction: (moduleName: string) => string;
 }): string => {
+  // we don't want to resolve the actual `jsdom` env if `jest-environment-jsdom` is not installed
+  if (filePath === 'jsdom') {
+    filePath = 'jest-environment-jsdom';
+  }
+
   try {
     return resolveWithPrefix(undefined, {
       filePath,
@@ -108,7 +113,7 @@ export const resolveTestEnvironment = ({
       rootDir,
     });
   } catch (error: any) {
-    if (filePath === 'jsdom' || filePath === 'jest-environment-jsdom') {
+    if (filePath === 'jest-environment-jsdom') {
       error.message +=
         '\n\nAs of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.';
     }