feat: support slowTestThreshold option
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
May 16, 2022
Comment on lines
+16
to
+18
| jest.mock('../formatter.js'); | ||
|
|
||
| jest.mocked(formatTsdResults).mockReturnValue('<mocked failure message>'); |
There was a problem hiding this comment.
This is a workaround, can’t use module factory because of jestjs/jest#12422. All mock types is a joy to work with, so I’m fine with that little trade off.
mrazauskas
commented
May 16, 2022
| ancestorTitles: [], | ||
| failureDetails: [], | ||
| failureMessages: errorMessage ? [errorMessage] : [], | ||
| fullName: TEST_TITLE, |
There was a problem hiding this comment.
Currently fullName is set to absolute path of the test file. Not sure if this is a breaking change, or just a fix?
There was a problem hiding this comment.
seems fine - we expose the filename via testFilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just could not stop myself – added support for
slowTestThresholdoption.Had to rewrite the logic, but that is even better after types were added. I mean, in some files there are more types than code. After refactor all is much cleaner.