Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds toBeDate() #118

Merged
merged 4 commits into from
Apr 19, 2018
Merged

Adds toBeDate() #118

merged 4 commits into from
Apr 19, 2018

Conversation

thiagodp
Copy link
Contributor

First step to #117

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Add yourself to contributors list (yarn contributor)

@thiagodp thiagodp mentioned this pull request Apr 16, 2018
@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #118   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          88     90    +2     
  Lines         413    425   +12     
  Branches       69     71    +2     
=====================================
+ Hits          413    425   +12
Impacted Files Coverage Δ
src/matchers/toBeDate/index.js 100% <100%> (ø)
src/matchers/toBeDate/predicate.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8ac8b...8d1590c. Read the comment docs.

@thiagodp
Copy link
Contributor Author

BTW, Travis CI is passing for Node 8 but failing for Node 6.

@mattphillips
Copy link
Member

This looks great @thiagodp thanks a lot 😄

@mattphillips mattphillips merged commit 1882d36 into jest-community:master Apr 19, 2018
@mattphillips
Copy link
Member

I've published this in v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants