fix(no-deprecated-functions): mark jest as an optional peer dependency #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to see a fix for this @jdanil as we are running into this with our shareable setup 👍 |
G-Rath
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
## [25.2.3](v25.2.2...v25.2.3) (2021-11-04) ### Bug Fixes * **no-deprecated-functions:** mark jest as an optional peer dependency ([#970](#970)) ([f468752](f468752))
|
🎉 This PR is included in version 25.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for updating the lockfile! Forgot the |
Open
10 tasks
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest/no-deprecated-functionsrequiresjestif a version isn't explicitly set in the config to automatically detect it from jest'spackage.jsonmanifest file.As
jestisn't declared as a dependency ofeslint-plugin-jest, stricter node linkers like pnp and pnpm throw errors when trying to run the rule.I opted to add it as an optional peer dependency as some consumers may explicitly declare their jest version in their eslint config, may not be using this specific rule, or
eslint-plugin-jestmay be included in a shareable eslint config that runs on some packages that may not include jest tests.