Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run git hooks when in ci #783

Merged
merged 1 commit into from
Mar 7, 2021
Merged

ci: don't run git hooks when in ci #783

merged 1 commit into from
Mar 7, 2021

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 7, 2021

Husky now doesn't handle checking if you're in CI, so we have to ourselves.

This prevented #782 from going out.

@G-Rath G-Rath requested a review from SimenB March 7, 2021 18:59
@SimenB
Copy link
Member

SimenB commented Mar 7, 2021

I think skipping the install is better

@SimenB
Copy link
Member

SimenB commented Mar 7, 2021

Semantic release should skip hooks when they commit, but that's a different issue 😅

package.json Outdated
@@ -78,7 +78,8 @@
]
},
"dependencies": {
"@typescript-eslint/experimental-utils": "^4.0.1"
"@typescript-eslint/experimental-utils": "^4.0.1",
"is-ci": "^3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev dep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pinst deals with it so it's not actually published as a postinstall)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it'd be nice if yarn v2 supported prepare 😞)

@G-Rath G-Rath merged commit 9e90d31 into main Mar 7, 2021
@G-Rath G-Rath deleted the disable-husky-in-ci branch March 7, 2021 19:26
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

🎉 This PR is included in version 24.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 8, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants